eosnetworkfoundation / eos-evm-contract

EOS EVM
Other
22 stars 15 forks source link

Add support for storage and overhead price #750

Closed elmato closed 3 months ago

elmato commented 3 months ago

Seems fine, but two issue: 1 will gas_price and gas_prices cause confusion? 2 when we upgrade from v2 to v3, we stop using gas_price_queue. seems there missing some mechanism to clear the value stored (if any) n that table afterwards?

1) They are similar but the types/functions/actions are very different. We couldn't find a better name for the pair storage_price/overhead_price :/.

2) ~We don't allow the change from v2 to v3 if there are pending prices in the queue~. Seems that check is missing in the current PR. Will update it