Scan Build Security Issues (15)

[ericpassmore]

Pull Request To Fix 15 Security Issues

Ask from Ledger to fix these issues to keep the app alive. Otherwise will be deprecated. Issues from make scan-build.

fixes #5, fixes #6, fixes #7, fixes #11, fixes #9, fixes #8, fixes #10, fixes #13, fixes #14, fixes #16, fixes #15, fixes #22, fixes #24, fixes #26, fixes #23, fixes #25, fixes #18, fixes #17

• main fixed a pointer compat issue in a strcpy. Cast receiving string to (char ) from volitile char
• main moved to secure string copy using sizeof receiving object
• eos_parse removed unread variable
• eos_parse moved to secure strcat for 1 char addition
• added string.h header to resolve memove undef
• correct size in strlcat
• back to inline defined strings for string copy, had undefined vars
• re-ordered statements to build buffer and then make assignment removing dead code
• removed un-used buffer-length in eos_stream
• eos_stream.c proper declaration of static inline func
• main.c cast (char *) for volatile strings in UX steps
• fixes spelling errors in comments for eos_stream.c
• fixed bug in bufferLength calc eos_parse_eosio.c
• fixed implicit declared function by including header file in eos_parse_eosio.c
• secured strcpy by moving to strlcpy
• ignore unneeded read value returned from call only using pass by reference size
• ignore signature length, for ecdsa always 64
• "wrapped channel parameter in UNUSED, call pattern needed to support external event
• clarified bagl_element_t param unused

[ericpassmore]

LGTM

Thanks