search

eosnetworkfoundation / mandel-eosjs

Official Javascript Library for Working with EOS Blockchain
Other
22 stars 6 forks source link

Remove bn library and use native BigInt #56

Closed ericpassmore closed 1 year ago

ericpassmore commented 1 year ago

Remove bignumber npm package and use native BigInt function. Check before and after size of package to measure improvement.

juanm95 commented 1 year ago

the Elliptic package that we use also has BN as a dependency, so in order to fully get rid of it we might have to abandon Elliptic.

ericpassmore commented 1 year ago

That is a good point. I removed the good first issue tag. Considering closing this as won't fix.

juanm95 commented 1 year ago

Is Elliptic an industry standard package or something? Maybe we try out another package that can do the same but without that BN dependency. If we can replace Elliptic I think it'd be worth doing, though maybe later.

ericpassmore commented 1 year ago

Elliptic is an industry standard package. I suggestion we look at updating elliptic to remove the bn.js dependency first, and only change to another encryption curve package if they would not take our fix.

Closing this issue with comment