eosnetworkfoundation / mandel-eosjs

Official Javascript Library for Working with EOS Blockchain
Other
22 stars 7 forks source link

fix: removed deprecated text-encoding package for text-encoder package #58

Closed AlexGriffith10 closed 1 year ago

AlexGriffith10 commented 1 year ago

Change

Original Issue: https://github.com/eosnetworkfoundation/mandel-eosjs/issues/4

The text-encoding package has been deprecated so I've substituted it with the text-encoder package made for node. This is only used in tests so should be low impact. Tests are all passing. I did have to add the types to the repo since typescript is set to not allow for any typing

Screenshot 2023-04-25 at 11 03 58 AM

Listing of Commits

fix: removed deprecated text-encoding package for text-encoder package

Listing of Files Changed

modified:   README.md
modified:   docs/2.-Transaction-Examples.md
modified:   docs/3.-Browsers.md
modified:   package-lock.json
modified:   package.json
modified:   src/tests/eosjs-api.test.ts
modified:   src/tests/serialization.test.ts
modified:   src/tests/strict-serialization.test.ts
new file:   src/types/@custom_encoder_types/text-encoder.d.ts
modified:   tsconfig.json
modified:   yarn.lock

API Changes

N/A

Documentation Additions

Updated documentation in repo to point to new package.

juanm95 commented 1 year ago

Can we just use the TextEncoder/TextDecoder that we get from the node utils? https://nodejs.org/api/util.html#class-utiltextencoder

We are already using it in src/tests/node.js and I tried it in our other unit tests and it worked there.

AlexGriffith10 commented 1 year ago

Can we just use the TextEncoder/TextDecoder that we get from the node utils? https://nodejs.org/api/util.html#class-utiltextencoder

We are already using it in src/tests/node.js and I tried it in our other unit tests and it worked there. good catch