search

eosnetworkfoundation / mandel-eosjs

Official Javascript Library for Working with EOS Blockchain
Other
22 stars 6 forks source link

Change calls to substr to use substring instead #60

Closed juanm95 closed 1 year ago

juanm95 commented 1 year ago

Change

Updating calls to substr to use substring instead. For the most part this is a straight forward change in our code and we can just replace "substr" with "substring" and call it a day. In some places where we do "substr(x, i)" where "x" is more than 0 and "i" is the amount of characters we want to include, we have to instead replace with "substring(x, i + x)".

Listing of Commits

7c156ee (HEAD -> jm/20-substr, origin/jm/20-substr) Substr changed to substring

Listing of Files Changed

src/eosjs-numeric.ts src/eosjs-serialize.ts src/tests/node.js src/tests/web.html

API Changes

None

Documentation Additions

None

juanm95 commented 1 year ago

it would be awesome if you could change some of these single letter variables to have meaningful names

Done, these files really need a more thorough cleanup, but renaming the vars helps, even if most just went from "s" to "str"