eosnetworkfoundation / mandel-eosjs

Official Javascript Library for Working with EOS Blockchain
Other
22 stars 6 forks source link

Removed unused dependencies including 'eosjs-ecc' #61

Closed kellytran3k closed 1 year ago

kellytran3k commented 1 year ago

Change

Fixes these relevant issues: https://github.com/eosnetworkfoundation/mandel-eosjs/issues/57, https://github.com/eosnetworkfoundation/mandel-eosjs/issues/59

I removed unused dependencies including eosjs-ecc by scoping out depcheck and running npm test-all after every npm uninstall <unused_dependency>

Dependencies removed:

I also modified the package.json file's scripts to run npm instead of yarn. This is a part of https://github.com/eosnetworkfoundation/mandel-eosjs/issues/12. Further clean up will be done in a separate ticket.

Testing

I used modified version of npm test-all to test against the removed dependencies. NOTE: Cypress test was failing. Investigation could be further discussed with team.

juanm95 commented 1 year ago

I see the yarn.lock still there and modified, but your comment said you deleted it, maybe it got added back on or something?

ericpassmore commented 1 year ago

validated docs generation with the command node_modules/typedoc/bin/typedoc --plugin typedoc-plugin-markdown