search

eosnetworkfoundation / mandel

Obsolete. Use https://github.com/AntelopeIO/leap instead.
Other
87 stars 30 forks source link

Backport: [statehist] Use generated abi for ship #469

Open vladtr opened 2 years ago

vladtr commented 2 years ago

Use generated abi for ship, Requested PR should update the abieos submodule and utilize the generated generated ship abi json instead of the hard coded one.

https://github.com/EOSIO/eos/pull/10882

spoonincode commented 2 years ago

fwiw, my understanding of that change seems backwards then what I'd expect. That change seemed like it was making ship_protocol.hpp in abieos be the source of truth for nodeos. It's weird imo to have abieos -- a serialization library -- defining the truth for how ship should work in nodeos.

Quite possibly ship_protocol.hpp should be part of mandel repo.

Anyways, this likely deserves further discussion somewhere before proceeding I think

spoonincode commented 1 year ago

Some work done in AntelopeIO/leap#458