eosnetworkfoundation / mandel

Obsolete. Use https://github.com/AntelopeIO/leap instead.
Other
87 stars 27 forks source link

Increase default transaction-retry-max-expiration-sec from 90 to 120 #800

Closed aaroncox closed 2 years ago

aaroncox commented 2 years ago

I'm petitioning for this small change to this default parameter.

https://github.com/eosnetworkfoundation/mandel/blob/b5fff95824aef97b2aff1fc02959b9b448001690/plugins/chain_plugin/chain_plugin.cpp#L327-L328

I'd like to see it increased from 90 to 120, to match the default expiration that many apps have baked into their transactions these days. Any app using the eosio-core SDK by default is going to create transactions that have a 120 expiration, if no expiration is specified.

https://github.com/greymass/eosio-core/blob/35bf93146b7b25203c21e69c14351810dca41e66/src/api/v1/types.ts#L330

If the developers swap from push_transaction to send_transaction2 and intend on using the retry feature, they'll have to then go back and change the expiration as well once they get the error (which isn't super intuitive). So long as there's no major concerns with a 120 default, for ease of developer adoption I'd say we should align these numbers and make the default 120 in nodeos.