Closed normyx closed 6 years ago
Hi @normyx
Thanks for your PR! Before we merge, just two questions.
It looks like you added a few commands:
{
...
+ command: this.translate("CMD_SWITCH_OFF"),
+ description : this.translate("CMD_SWITCH_OFF_DESCRIPTION"),
+ callback : 'cmd_asstnt_switch_off',
+ },
+ {
+ command: this.translate("CMD_PAGE_INCR"),
+ description : this.translate("CMD_PAGE_INCR_DESCRIPTION"),
+ callback : 'cmd_asstnt_page_incr',
+ },
...
et.al.
Thanks again.
Hi, I confirm it is a mistake in the PR, this was a specific implem from my side, for Raspi.
@normyx Thanks for the feedback. Can you make a new PR without the custom commands?
@normyx
I'll integrate this manually. How does the module work for you with the new GA SDK?
Feel free to post in our issues if you have any.
PS. I have also opened a dev
branch you can send future PRs to.
If you want to integrate this upgrade