eouia / MMM-Assistant

(Deprecated) This project is not supported any more from original owner. Use alternative MMM-AssistantMk2(https://github.com/eouia/MMM-AssistantMk2)
https://github.com/eouia/MMM-AssistantMk2
MIT License
25 stars 8 forks source link

modification to support new GA SDK to support new languages #29

Closed normyx closed 6 years ago

normyx commented 6 years ago

If you want to integrate this upgrade

E3V3A commented 6 years ago

Hi @normyx

Thanks for your PR! Before we merge, just two questions.

It looks like you added a few commands:

{
...
+          command: this.translate("CMD_SWITCH_OFF"),
+          description : this.translate("CMD_SWITCH_OFF_DESCRIPTION"),
+          callback : 'cmd_asstnt_switch_off',
+        },
+        {
+          command: this.translate("CMD_PAGE_INCR"),
+          description : this.translate("CMD_PAGE_INCR_DESCRIPTION"),
+          callback : 'cmd_asstnt_page_incr',
+        },
...

et.al.

Thanks again.

normyx commented 6 years ago

Hi, I confirm it is a mistake in the PR, this was a specific implem from my side, for Raspi.

E3V3A commented 6 years ago

@normyx Thanks for the feedback. Can you make a new PR without the custom commands?

E3V3A commented 6 years ago

@normyx I'll integrate this manually. How does the module work for you with the new GA SDK? Feel free to post in our issues if you have any. PS. I have also opened a dev branch you can send future PRs to.