search

eouia / MMM-CalendarExt

Calendar views for MagicMirror
MIT License
57 stars 18 forks source link

Weekly entries don't sort properly #14

Closed tsneidin closed 7 years ago

tsneidin commented 7 years ago

The recurring entry in the first week is not properly sorted. It also appears that sorting across multiple calendars is not working as seen in the second week.

capture

eouia commented 7 years ago

Ok, I’ll check. Would you mind giving your ics url for exact test?(if you don’t mind...)

eouia commented 7 years ago

@tsneidin I fix it now. sorry for bugs.

tsneidin commented 7 years ago

Thank you. I will test later today and thank you for the fine calendar module.

I'm trying to make the calendar display as compact as possible. To this end I've got a couple ideas.

  1. Remove subtitle from weekly view. I suggest this:

line 188 render.js case "weekly": if (!cfg.subtitleFormat) { title = moment(md).startOf('week').format(cfg.titleFormat)

  1. remove entries from weekly view that have already occurred.

Are these enhancements you'd be willing to add?

Thanks.

On Wed, Oct 4, 2017 at 3:38 AM, eouia notifications@github.com wrote:

@tsneidin https://github.com/tsneidin I fix it now. sorry for bugs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eouia/MMM-CalendarExt/issues/14#issuecomment-334087846, or mute the thread https://github.com/notifications/unsubscribe-auth/AOozt9-6e4QfHoxM6hcB2aOkHfhcScm0ks5so0QfgaJpZM4PsmfA .

-- Todd Neidinger

tsneidin commented 7 years ago

In my testing I'm still seeing that all day events sort at the top of weekly view even with most recent version

[image: Inline image 1]

On Wed, Oct 4, 2017 at 8:44 AM, Todd Neidinger tneidinger@gmail.com wrote:

Thank you. I will test later today and thank you for the fine calendar module.

I'm trying to make the calendar display as compact as possible. To this end I've got a couple ideas.

  1. Remove subtitle from weekly view. I suggest this:

line 188 render.js case "weekly": if (!cfg.subtitleFormat) { title = moment(md).startOf('week').format(cfg.titleFormat)

  • " - "
  • moment(md).endOf('week').format(cfg.titleFormat) }else{ title = (isThisYear) ? md.format(cfg.titleFormat) : md.format(cfg.overTitleFormat) subtitle = moment(md).startOf("week").format(cfg.subtitleFormat)
    • " - "
    • moment(md).endOf("week").format(cfg.subtitleFormat) } break
  1. remove entries from weekly view that have already occurred.

Are these enhancements you'd be willing to add?

Thanks.

On Wed, Oct 4, 2017 at 3:38 AM, eouia notifications@github.com wrote:

@tsneidin https://github.com/tsneidin I fix it now. sorry for bugs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eouia/MMM-CalendarExt/issues/14#issuecomment-334087846, or mute the thread https://github.com/notifications/unsubscribe-auth/AOozt9-6e4QfHoxM6hcB2aOkHfhcScm0ks5so0QfgaJpZM4PsmfA .

-- Todd Neidinger

-- Todd Neidinger

eouia commented 7 years ago

@tsneidin Thanks for your suggestion.

For weekly subtitle.

For sorting fulldayEvent priority.

eouia commented 7 years ago

Have you any more issue? I'll close this.