search

eousphoros / mod-spdy

OpenSSL 1.0.2 and Apache 2.4.12 port for mod-spdy
Other
79 stars 23 forks source link

Update to httpd 2.4.10 #11

Closed Noctem closed 10 years ago

Noctem commented 10 years ago

Update to httpd 2.4.10, update APR to 1.5.1, update the mod_ssl patch to work with 2.4.10 and add the latest NPN code changes from the Apache SVN.

eousphoros commented 10 years ago

Awesome pull request. Give me a little bit of time to parse it and I will most likely merge it in. Thank you!

Noctem commented 10 years ago

Great, thanks. Let me know if anything needs to be changed. I mainly went through the diff between 2.4.10 and the current svn trunk and cut out portions that were not relevant to NPN by hand, so it's possible that I missed something along the way. Hopefully it's not too hard to identify the changes, I always hate trying to decipher a diff of a diff.

Do you think I should submit this patch to the Apache Software Foundation somehow? Or will they just be syncing with your fork for the time being? I looked at their bug tracker and I didn't see any areas for mod_spdy anywhere, which is understandable considering ownership was transferred to them so recently.

accolon commented 10 years ago

Just a small note because the description of the "master" branch still says "OpenSSL 1.0.1(h) and Apache 2.4.7 port for mod-spdy":

Using the resulting mod_ssl.so from this updated version with Apache 2.4.7 (which is default on Ubuntu 14.04 LTS) seems to work fine in general, but mod_spdy fails with "WARNING:mod_spdy.cc(437)] NPN didn't happen during SSL handshake. You're probably using a version of mod_ssl that doesn't support NPN." errors.

It took me quite some time to see the older 2.4.7 branch which actually works on the current Ubuntu LTS. ;-)

Thanks for the port, btw! :-)

eousphoros commented 10 years ago

Thank you for the reminder. I updated the readme.