eousphoros / mod-spdy

OpenSSL 1.0.2 and Apache 2.4.12 port for mod-spdy
Other
79 stars 23 forks source link

NPN doesn't advertise HTTP/1.1 #19

Closed redstar3894 closed 10 years ago

redstar3894 commented 10 years ago

Glad this is finally working after Pull #17, but I'm running into the following issue:

Reference: https://www.ssllabs.com/ssltest/analyze.html?d=mach3.redragon.me&hideResults=on http://spdycheck.org/#mach3.redragon.me

It looks like while mod_spdy is working properly, advertising and negotiating SPDY sessions, it doesn't seem to advertise http/1.1 as a fallback. Not sure if this has to do with how the new NPN API works, but could we remove the separate http/1.1 function and checks and always advertise http/1.1? As it stands currently, it checks for http/1.1 support and doesn't advertise it if the server should be advertising it elsewhere.

We should just be able to add http/1.1 support similarly to how @eousphoros added SPDY/3.1 in commit 314aa59c41c0da143d9f4ea23931d814ef6126ac , but correct me if I'm wrong here.

Configuration: CentOS 6.5 / cPanel VPS Apache 2.4.10 w/Event MPM

bipinu commented 10 years ago

Can confirm! I ran into the same issue.

ghostwheel42 commented 10 years ago

Yes, sorry, I unfortunately removed the http advertisement and didn't double check later. Just a minute...

redstar3894 commented 10 years ago

20 seems to have solved it!

https://www.ssllabs.com/ssltest/analyze.html?d=mach3.redragon.me&hideResults=on http://spdycheck.org/#mach3.redragon.me

Thanks @ghostwheel42 !