AF Rest endpoint - Modern Theme CRUD

eoverfield commented 6 years ago

Azure function based api end point to work with modern theming.

Key points: This endpoint will begin to define the architectural blueprint for all other api endpoints. Issues to consider.

Should provide basic security to ensure that the current calling user is a member of the domain. recommended path: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/connect-to-api-secured-with-aad#build-an-api-secured-with-azure-ad
Should utilize PnP Core to speak to SharePoint
Can we use .net standard 2.0 or will that not work? Too ambitious and pnp core is not yet standard 2.0 ready?
Connect to SharePoint using Auth only aad app so that we are not bound to the calling user. Will be used in other endpoints where tenant admin required, yet would like to open up specific aspects to other users. i.e. site designs.
Consider addition of secondary permission model to allow us to lock down AF based on much more granular permissions, yet permissions that are separate from AD. Nice to have.
Ideally is somehow extendable. Consider where a project member wants to end the codebase, or possibly override something. They do not have to touch the base code, rather they can include a partial class to provide more functionality. This will allow for an easier upgrade.

Verb: Get

Action: Get all custom themes or get one theme

Verb: Delete

Action: Delete a custom modern theme

Verb: Post

Action: Add a new modern theme, provide theme file

Verb: Patch

Action: update a provided theme

wobba commented 6 years ago

It's easier to go .Net standard vs Core for now, mostly due to Core being shitty supported in tooling for Azure Functions (per last week). Shouldn't really matter much, and could possible move later on when it's more mature.

eoverfield commented 6 years ago

Ok, signing up for a V2 already:) I like it. The best technology available today, that gets the job done in a reasonable manner seems best to me. I trust you judgement.

wobba commented 6 years ago

Still a bug with graph/AAD calls in SPFx, so cannot properly test this in my tenants.

eoverfield commented 6 years ago

is it wrong to say, "Im shocked..."

eoverfield / huddle

AF Rest endpoint - Modern Theme CRUD #2