eoyilmaz / displaycal-py3

DisplayCAL Modernization Project
https://eoyilmaz.github.io/displaycal-py3/
GNU General Public License v3.0
773 stars 56 forks source link

All ΔE values = 0 during testchart #295

Closed umtiagopereira closed 6 months ago

umtiagopereira commented 11 months ago

All the dE values of the verification testchart report are equal to 0. This seems to be an issue that just happens with this python3 version of displaycal.

CleanShot 2023-10-06 at 12 55 09

MUWalter commented 10 months ago

Yes, I have the same bug. How can it be fixed?

quietvoid commented 8 months ago

This seems to be a duplicate of #276 which is supposed to be fixed but there hasn't been a new release yet. I'll try running a verification on the latest develop commit later to try.

quietvoid commented 8 months ago

Right, on the develop branch this issue is fixed for me.

Shnub commented 8 months ago

I'm also getting all measured values identical to nominal values and thus all color distances as 0 in measurement reports generated with 3.9.11. I'm not sure this issue is really identical to #276 since measured values seemed correct there... Though it is definitely identical to #285.

Anyway, I tried the develop branch but then when clicking "Start Measurement" for the verification, DisplayCAL crashes with the following Terminal output:

2024-01-12 21:44:35.903 Python[32111:2213156] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'NSWindow drag regions should only be invalidated on the Main Thread!'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007ff80d0cd11a __exceptionPreprocess + 242
    1   libobjc.A.dylib                     0x00007ff80cbf30b7 objc_exception_throw + 48
    2   CoreFoundation                      0x00007ff80d0f5296 -[NSException raise] + 9
    3   AppKit                              0x00007ff810118e2e -[NSWindow(NSWindow_Theme) _postWindowNeedsToResetDragMarginsUnlessPostingDisabled] + 307
    4   AppKit                              0x00007ff810105344 -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 1227
    5   AppKit                              0x00007ff810104e72 -[NSWindow initWithContentRect:styleMask:backing:defer:] + 42
    6   libffi.dylib                        0x00007ff81d6508c2 ffi_call_unix64 + 82
    7   ???                                 0x00007000041f6750 0x0 + 123145371477840
)
libc++abi: terminating due to uncaught exception of type NSException
bash: line 1: 32111 Abort trap: 6           displaycal
make: *** [launch] Error 134

Appears to be macOS-specific issue...?

MUWalter commented 8 months ago

I am also on the latest develop branch and this issue isn't fixed for me.

eoyilmaz commented 6 months ago

I cannot reproduce this on my Macbook Pro with M1 Pro, and I'll release 3.9.12 soon, please test it again afterwards...

image

eoyilmaz commented 6 months ago

I'll close this, please open it again if you think it is not working for you.

MUWalter commented 6 months ago
Bildschirmfoto 2024-03-18 um 15 19 26

I am still getting only 0 as values. I just installed the latest version. I am on a Macbook Pro M2 Max @Sonoma 14.4. develop branch

I get this as an error message:

Bildschirmfoto 2024-03-18 um 15 25 54
eoyilmaz commented 6 months ago

3.9.12 is released. Can you please try it.

MUWalter commented 6 months ago

3.9.12 is released. Can you please try it.

Works like a charm. Although I have to admit that I didn't know that you had to delete everything before so Displaycal gets an actual update. I guess I was still using 3.9.11 standard version. Anyway, following the instructions, I got an error message (both ways) installing it, as displaycal doesn't seem to open when python 3.12 is installed. Unfortunately phyton 3.12 gets installed when doing it according to the instructions. My workaround was to download version 3.11 dmg, install the package and then skip the python part in the instructions: https://www.python.org/downloads/release/python-3118/

But nevertheless great work, now everything I need works for me! Thank you very much for all the effort you put into this!

All the best, Mark

[

Bildschirmfoto 2024-03-22 um 10 33 27

](url)

eoyilmaz commented 6 months ago

Glad to hear that it is okay now, closing this 👍