Minor documentation update; tweak to Makefile to deal with python version issues.

rickdoesdev commented 2 months ago

While trying to set this up today on Fedora 39 I hit a few issues which were mostly addressed in replies to various issues.

Just writing up a couple of key gotchas that seem to hit a few people.

Need to install python3-devel.
- Added only to Fedora reqs as I don't have a Debian install to test at present.
- OSX doesn't seem to require anything special it worked out of the box.
Notes about supported python versions
- Updated the support range to highlight 3.12 works now (based on the fact that it works for me, and that recent commits in develop enabled it)
- Updated the notes around failing back to manual install and using the correct python version to setup the venv
- Documented use of new Makefile variable (see below)

Also added a new Makefile variable SYSTEM_PYTHON which defaults to python3 as it already did, but now can be overridden with a different python binary to call the venv. Once this is setup it seems like it just works.

rickdoesdev commented 2 months ago

I do notice an inconsistency between the Makefile and the readme. The Makefile called python3 even inside the venv. The readme manual docs suggest calling python to create the venv. I know on most systems this should still just work as expected but should one of these be changed to be consistent with the other?

rickdoesdev commented 2 months ago

Also apologies for just dropping a change unprompted, I probably should have raised an issue first to ask if this was even desired.

p5k369 commented 2 months ago

Hey @rickdoesdev , thank you for your PR.

Updated the support range to highlight 3.12 works now (based on the fact that it works for me, and that recent commits in develop enabled it)

Please note that this is not the case. It is entirely possible that you personally not encounter any problems running displaycal with python-3.12. However, the GUI framework used by displaycal is wxPython in the latest version 4.2.1, which according to wxPython itself is considered a beta in conjunction with Python 3.12.

In fact there is already an issue with python-3.12 which prevents displaycal to close without segmentation fault. #341

rickdoesdev commented 2 months ago

@p5k369 ah good to know, I just saw a bunch of .12 increases in the develop config files and assumed developwas close enough.

I'll revert that out of this branch!

eoyilmaz / displaycal-py3

Minor documentation update; tweak to Makefile to deal with python version issues. #351