ep2p / kademlia-netty

Java implementation of Kademlia DHT using netty and abstraction layer
MIT License
0 stars 1 forks source link

Improve serialization/deserialization logic #8

Closed sepgh closed 1 year ago

sepgh commented 1 year ago

https://github.com/ep2p/kademlia-netty/blob/b7e9ad88670e78b17af296327711bc16f1314654/src/main/java/io/ep2p/kademlia/netty/serialization/KademliaMessageDeserializer.java#L49-L65

Above code makes me cry

sepgh commented 1 year ago

This issue is no longer in the context of this repository since kademlia gson serialization has its own repository.

Solved: https://github.com/ep2p/kademlia-serialization-gson/blob/60e07a327f479b97fc0925382f031f641fb6e2e5/src/main/java/io/ep2p/kademlia/serialization/gson/KademliaMessageDeserializer.java#L34-L64