epacke / BigIPReport

Overview of your loadbalancer configuration
https://loadbalancing.se
8 stars 2 forks source link

Feature/html #71

Closed timriker closed 6 years ago

timriker commented 6 years ago

I hope this set is small enough to review. The first section has whitespace, but the rest are actual code changes.

All pretty minor changes and all to the main script. Output looks much better on W3C validator.

epacke commented 6 years ago

Hi Tim! How about having a short meeting one of these days? Would feel good to e-meet. :) Will test this soon and get back to you.

/Patrik

timriker commented 6 years ago

Life is pretty busy for me at the moment. I'll be offline and out of town for a week or so. There are more files under Move.... that could get whitespace cleaned. I'm testing different options to avoid the string concatenation slowness now. Here's an example: https://pastebin.com/3486anmq Keep in mind that for me the script is probably doing millions of contatinations. My last run took 88 minutes as I posted earlier. Almost all of that is generating the html. Ideally the interface would load all the data in json, and then render the visible entries in a table only. Also it would be nice if the UI was visible and the "pace" bar was only over where the table will end up. It takes a couple minutes for the page to load. I'll time that more precisely.

epacke commented 6 years ago

I will try the string builder today. It was an excellent idea.

timriker commented 6 years ago

The last example wins by speed. That one uses: System.Collections.Generic.List[System.String] Thoughts on that?

epacke commented 6 years ago

Darn, I missed that one. Lemme get back to you.