epakai commented 7 years ago

BTS_msg_id: 20141007185456.21078.51330.reportbug@darkflame.darkskies.za.net BTS author: Norman Rasmussen norman@darkskies.za.net

Package: synergy Version: 1.4.16-1 Severity: normal Tags: upstream patch

Since Chrome 31, synergy has broken mouse hover if Chrome uses hardware acceleration.

The upstream bug [1] has a patch to work around the X11 bug that causes this in comment #65.

Multiple people has confirmed that the patch works-for-them on the bug.

[1] Upstream bug: http://synergy-project.org/spit/issues/details/3819/

-- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (700, 'testing'), (650, 'stable'), (600, 'unstable'), (550, 'experimental') Architecture: i386 (x86_64) Foreign Architectures: amd64

Kernel: Linux 3.14-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash

Versions of packages synergy depends on: ii libc6 2.19-7 ii libcrypto++9 5.6.1-6 ii libcurl3-gnutls 7.37.1-1 ii libgcc1 1:4.9.1-4 ii libice6 2:1.0.9-1 ii libqt4-network 4:4.8.6+git49-gbc62005+dfsg-1 ii libqtcore4 4:4.8.6+git49-gbc62005+dfsg-1 ii libqtgui4 4:4.8.6+git49-gbc62005+dfsg-1 ii libsm6 2:1.2.2-1 ii libstdc++6 4.9.1-4 ii libx11-6 2:1.6.2-2 ii libxext6 2:1.3.2-1 ii libxi6 2:1.7.4-1 ii libxinerama1 2:1.1.3-1 ii libxtst6 2:1.2.2-1

synergy recommends no packages.

synergy suggests no packages.

-- no debconf information

epakai commented 7 years ago

BTS_msg_id: 20141009140801.GA21901@perseus.local BTS author: Alberto Garcia berto@igalia.com

On Tue, Oct 07, 2014 at 07:54:56PM +0100, Norman Rasmussen wrote:

Since Chrome 31, synergy has broken mouse hover if Chrome uses hardware acceleration.

This was working fine with Debian Chromium <= 35. With Chromium 37 I'm experiencing the problem that you describe.

Berto

epakai commented 7 years ago

BTS_msg_id: 20141009144103.GA23061@perseus.local BTS author: Alberto Garcia berto@igalia.com

--17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline

On Tue, Oct 07, 2014 at 07:54:56PM +0100, Norman Rasmussen wrote:

Multiple people has confirmed that the patch works-for-them on the bug.

I just tried it here too and it works fine, I refreshed it against synergy from sid in case you want to use it in the package.

Berto

--17pEHd4RhPHOinZp Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="x11-mouseover.patch"

Index: synergy-1.4.16/src/lib/platform/CXWindowsScreen.cpp

--- synergy-1.4.16.orig/src/lib/platform/CXWindowsScreen.cpp +++ synergy-1.4.16/src/lib/platform/CXWindowsScreen.cpp @@ -1781,28 +1781,26 @@ CXWindowsScreen::doSelectEvents(Window w // SubstructureNotifyMask in order to get CreateNotify events so we // select events on new windows too. //

// note that this can break certain clients due a design flaw of X.
// X will deliver a PointerMotion event to the deepest window in the
// hierarchy that contains the pointer and has PointerMotionMask
// selected by any client. if another client doesn't select
// motion events in a subwindow so the parent window will get them
// then by selecting for motion events on the subwindow we break
// that client because the parent will no longer get the events.
// FIXME -- should provide some workaround for event selection
// design flaw. perhaps only select for motion events on windows
// that already do or are top-level windows or don't propagate
// pointer events. or maybe an option to simply poll the mouse.
// we don't want to adjust our grab window
if (w == m_window) {
return;
// X11 has a design flaw. If no client selected PointerMotionMask for
// a window, motion events will be delivered to that window's parent.
// If any client, not necessarily the owner, selects PointerMotionMask
// on such a window, X will stop propagating motion events to its
// parent. This breaks applications that rely on event propagation
// behavior.
//
// Avoid selecting PointerMotionMask unless some other client selected
// it already.
long mask = SubstructureNotifyMask;
XWindowAttributes attr;
XGetWindowAttributes(m_display, w, &attr);
if ((attr.all_event_masks & PointerMotionMask) == PointerMotionMask) {
mask |= PointerMotionMask; }

// select events of interest. do this before querying the tree so // we'll get notifications of children created after the XQueryTree() // so we won't miss them.
XSelectInput(m_display, w, PointerMotionMask | SubstructureNotifyMask);
XSelectInput(m_display, w, mask);

// recurse on child windows Window rw, pw, *cw;

--17pEHd4RhPHOinZp--

epakai commented 7 years ago

BTS_msg_id: CALJJsLsYWdmeo_v-CkSSobmtyOyRynrzxd7BN73T_uSkJk868g@mail.gmail.com BTS author: Jeremy Broad jeremy@broad.ca

Link to issue and original patch in their github issue queue.

https://github.com/synergy/synergy/issues/3749#issuecomment-58855790

Newer version of Synergy have patch/fix applied, but all versions in Debian repos are older.

Thanks

epakai commented 7 years ago

BTS_msg_id: 20170108110506.GA664@valiant.palfrader.org BTS author: Peter Palfrader weasel@debian.org

--y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline

Control: tags 764389 + pending

Hi!

I've uploaded an NMU for synergy (versioned as 1.4.16-1.2) to DELAYED/10.

Patch attached.

Cheers,

--y0ulUmNC+osPPQO6 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="synergy-1.4.16-1.2-nmu.diff"

diff -Nru synergy-1.4.16/debian/changelog synergy-1.4.16/debian/changelog --- synergy-1.4.16/debian/changelog 2016-10-24 06:36:22.000000000 +0200 +++ synergy-1.4.16/debian/changelog 2017-01-08 11:28:04.000000000 +0100 @@ -1,3 +1,12 @@ +synergy (1.4.16-1.2) unstable; urgency=medium +

- Non-maintainer upload.
- Apply patch from https://xzrq.net/x11-mouseover.patch as mentioned
in https://github.com/symless/synergy/issues/3749#issuecomment-58855820
to fix X11 mouse-over issue on synergy server (closes: #764389).
-- Peter Palfrader weasel@debian.org Sun, 08 Jan 2017 11:20:13 +0100
synergy (1.4.16-1.1) unstable; urgency=medium
- Non-maintainer upload. diff -Nru synergy-1.4.16/debian/patches/series synergy-1.4.16/debian/patches/series --- synergy-1.4.16/debian/patches/series 2016-10-24 06:36:22.000000000 +0200 +++ synergy-1.4.16/debian/patches/series 2017-01-08 11:21:30.000000000 +0100 @@ -2,3 +2,4 @@ system-cryptopp.patch cprotocolutil-writef.patch versioncheck-disable.patch +x11-mouseover.patch diff -Nru synergy-1.4.16/debian/patches/x11-mouseover.patch synergy-1.4.16/debian/patches/x11-mouseover.patch --- synergy-1.4.16/debian/patches/x11-mouseover.patch 1970-01-01 01:00:00.000000000 +0100 +++ synergy-1.4.16/debian/patches/x11-mouseover.patch 2017-01-08 11:22:40.000000000 +0100 @@ -0,0 +1,54 @@ +Per https://github.com/symless/synergy/issues/3749#issuecomment-58855820 +from https://xzrq.net/x11-mouseover.patch: +fix X11 mouse-over issue on synergy server. +Index: synergy-1.4.16/src/lib/platform/CXWindowsScreen.cpp +=================================================================== +--- synergy-1.4.16.orig/src/lib/platform/CXWindowsScreen.cpp ++++ synergy-1.4.16/src/lib/platform/CXWindowsScreen.cpp +@@ -1780,29 +1780,32 @@ CXWindowsScreen::doSelectEvents(Window w
// that we select PointerMotionMask on every window. we also select
// SubstructureNotifyMask in order to get CreateNotify events so we
// select events on new windows too. +- // +- // note that this can break certain clients due a design flaw of X. +- // X will deliver a PointerMotion event to the deepest window in the +- // hierarchy that contains the pointer and has PointerMotionMask +- // selected by any client. if another client doesn't select +- // motion events in a subwindow so the parent window will get them +- // then by selecting for motion events on the subwindow we break +- // that client because the parent will no longer get the events. +- +- // FIXME -- should provide some workaround for event selection +- // design flaw. perhaps only select for motion events on windows +- // that already do or are top-level windows or don't propagate +- // pointer events. or maybe an option to simply poll the mouse.
// we don't want to adjust our grab window
if (w == m_window) {
return;
}
++ // X11 has a design flaw. If no client selected PointerMotionMask for ++ // a window, motion events will be delivered to that window's parent. ++ // If any client, not necessarily the owner, selects PointerMotionMask ++ // on such a window, X will stop propagating motion events to its ++ // parent. This breaks applications that rely on event propagation ++ // behavior. ++ // ++ // Avoid selecting PointerMotionMask unless some other client selected ++ // it already. ++ long mask = SubstructureNotifyMask; ++ XWindowAttributes attr; ++ XGetWindowAttributes(m_display, w, &attr); ++ if ((attr.all_event_masks & PointerMotionMask) == PointerMotionMask) { ++ mask |= PointerMotionMask; ++ } ++
// select events of interest. do this before querying the tree so
// we'll get notifications of children created after the XQueryTree()
// so we won't miss them. +- XSelectInput(m_display, w, PointerMotionMask | SubstructureNotifyMask); ++ XSelectInput(m_display, w, mask);
// recurse on child windows
Window rw, pw, *cw;

--y0ulUmNC+osPPQO6--

epakai commented 7 years ago

BTS_msg_id: E1cToky-0007Qh-8E@fasolo.debian.org BTS author: Peter Palfrader weasel@debian.org

Source: synergy Source-Version: 1.4.16-1.2

We believe that the bug you reported is fixed in the latest version of synergy, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is attached.

Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 764389@bugs.debian.org, and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software pp. Peter Palfrader weasel@debian.org (supplier of updated synergy package)

(This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org)

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256

Format: 1.8 Date: Sun, 08 Jan 2017 11:20:13 +0100 Source: synergy Binary: synergy Architecture: source Version: 1.4.16-1.2 Distribution: unstable Urgency: medium Maintainer: Jeff Licquia licquia@debian.org Changed-By: Peter Palfrader weasel@debian.org Description: synergy - Share mouse, keyboard and clipboard over the network Closes: 764389 Changes: synergy (1.4.16-1.2) unstable; urgency=medium .

Non-maintainer upload.
Apply patch from https://xzrq.net/x11-mouseover.patch as mentioned in https://github.com/symless/synergy/issues/3749#issuecomment-58855820 to fix X11 mouse-over issue on synergy server (closes: #764389). Checksums-Sha1: 20929bf745de2ff4baa6b1750c2ac0f846aab6dc 1636 synergy_1.4.16-1.2.dsc 4ce51f768330d8a088d259cbf18abf802cabbba6 17960 synergy_1.4.16-1.2.debian.tar.xz Checksums-Sha256: f7a539e0193e0d0134431b3b998f27204c070a100947aee9a02c709c656c7d21 1636 synergy_1.4.16-1.2.dsc 4a54434eb35ed1eca131ba699acde276d6b147b8c0eed6cc73b2a7b7373919a2 17960 synergy_1.4.16-1.2.debian.tar.xz Files: 4ab0ead20d7e1bcfaa742199bfe26362 1636 x11 optional synergy_1.4.16-1.2.dsc cbbb9efdc6a3dade29a989a76a41744a 17960 x11 optional synergy_1.4.16-1.2.debian.tar.xz

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1

iQEcBAEBCAAGBQJYchX1AAoJEIYCyCA4cjMfOKwIALBrgxfrFSPdFoM3EmITB8kb UEHoWtYoxMEHOFCWAj3IW2Rv9mT+7AsaIIMKA42y4Ai6joXLG2xCQS1Rw9jBLHTv NihOFggtMWmAItMB62HEjWvkTvDY7/vqshhdOfQaUC+USq8/GfI31Ju1aPQwk0Oa 9EQATvPP6as4mfEB1HHIAGAORe7YzUZCd/x30CjuoF8/9y49Mxp9VPPmuRaEAcy/ RPxrmGKpgMlMS5Vw8KkzgeBtRt1Gi3EW4xx3PHC3/CO/S506tNcBBNPzijD0tVNM 3MjsEb3q9nOwf+6o8TtEkDVNBGeGyx9w5AfSuNreDjcBZseCSuoR3xt5piXJrus= =sEex -----END PGP SIGNATURE-----

epakai commented 7 years ago

BTS_msg_id: Bug archived. BTS author: Debbugs Internal Request owner@bugs.debian.org

epakai / synergy-debian

[764389] synergy: Linux Chrome hover doesn't work #5

Index: synergy-1.4.16/src/lib/platform/CXWindowsScreen.cpp

A New Hope

A long time ago, in a galaxy far, far away

something happened.

Magically this resulted in the following

action being taken, but this fake control

message doesn't tell you why it happened

The action:

Bug archived.

This fakemail brought to you by your local debbugs

administrator