search

epam / CoroutinesCache

In mobile development exists solution for caching with RxJava usage, but there is no solutions for Kotlin Coroutines. The project is to provide this functionality to mobile community.
Apache License 2.0
162 stars 7 forks source link

Code style checks #9

Closed Dartlexx closed 5 years ago

Dartlexx commented 5 years ago

I think that this project would benefit if some Code Style checks would be used. Like KtLint and Detect.

Also, in several classes I noticed that nullable var field could be replaced with non-null lateinit or simple non-null field.

Record class is the main example of it:

    private var timeAtWhichWasPersisted: Long = 0
    private var dataClassName: String? = null
    private var dataCollectionClassName: String? = null
    private var dataKeyMapClassName: String? = null

These fields are changed only in init method.

Dartlexx commented 5 years ago

I have implemented code style checks in PR#21. The rest of proposal will be implemented as separate PR, because it will be big enough and I don't want it to meddle with simple code style fixes.

Dartlexx commented 5 years ago

Most of those other issues were closed in previous or existing Pull Requests. Closing the issue