Preview: We shouldn't allow to export canvas with nucleotides with no natural analog to Sequence format (and FASTA) - Githubissues

epam / Indigo

Universal cheminformatics toolkit, utilities and database search tools

http://lifescience.opensource.epam.com

Apache License 2.0

314 stars 103 forks source link

Preview: We shouldn't allow to export canvas with nucleotides with no natural analog to Sequence format (and FASTA) #2035

Closed AlexeyGirin closed 3 months ago

AlexeyGirin commented 4 months ago

Steps to Reproduce

Go to Macromolecules mode - Flex mode
Open RNA tab - Nucleotides section
Put 5NitInd nucleotide from the library on the canvas
Save canvas to Sequence format (or FASTA)

Actual behavior System let user to do that Sequence: FASTA:

Expected behavior Since we don't support import of monomers with no natural analog (as per https://github.com/epam/Indigo/issues/1466 and https://github.com/epam/Indigo/issues/1755) - we should not allow to export it. System should throw proper error in that case

Versions

Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
Windows 10 Pro
Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - https://github.com/epam/ketcher/issues/4382

AlexeyGirin commented 3 months ago

We decide to return Error in such case (by @AlexanderSavelyev and @vanoprenko )

Zhirnoff commented 3 months ago

Tested. Bug fixed. 2024-07-16_14h04_05

Desktop:

OS: Windows 11
Browser Chrome
Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version [Version 2.23.0-rc.3] Indigo version [Version 1.22.0-rc.3]

AlexeyGirin commented 3 months ago

Fixed.

Ketcher Version 2.23.0-rc.3 Build at 2024-07-14; 20:34:10
Indigo Toolkit Version 1.22.0-rc.3.0-gbb5c51fc2-wasm32-wasm-clang-19.0.0
Windows 10 Pro
Chrome Version 126.0.6478.127 (Official Build) (64-bit)