epam / Indigo

Universal cheminformatics toolkit, utilities and database search tools
http://lifescience.opensource.epam.com
Apache License 2.0
315 stars 105 forks source link

Sysmem should throw an error if we try to connect monomer to already occopied attachment point #2078

Closed AlexeyGirin closed 1 month ago

AlexeyGirin commented 3 months ago

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load using paste from clipboard IDT type: CHEM1{[MCC]}|RNA1{R(U)P}$CHEM1,RNA1,1:R1-1:R2$$$V2.0 image

Actual behavior System load something image

Expected behavior Error should occur - Can't connect to R2 attachment point of monomer index 1 of RNA1 - it is already occupied

Versions

Issue found while testing - https://github.com/epam/Indigo/issues/1188

AliaksandrDziarkach commented 1 month ago

Planed to fix with variant monomers helm support.

AlexeyGirin commented 1 month ago

Re-CHECK

split-ends commented 1 month ago

Successfully verified: an error appears with the corresponding message: image

Environment details: Ketcher Version: 2.25.0-rc.1 Build at 2024-09-03; 15:31:03 Indigo Version: 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0 Chrome Version: Version 128.0.6613.113 (Official Build) (64-bit) Windows 11 Enterprise