epam / Indigo

Universal cheminformatics toolkit, utilities and database search tools
http://lifescience.opensource.epam.com
Apache License 2.0
318 stars 104 forks source link

Preview: When Reaction Conditions text field is empty, clicking on placeholder text on canvas results in a blank line, with no visible text #2608

Closed Zhirnoff closed 18 hours ago

Zhirnoff commented 2 weeks ago

Steps to Reproduce

  1. Copy and Paste on canvas

    $RDFILE 1
    $DATM    11/05/24 13:20
    $RFMT
    $RXN
    
    -INDIGO- 1105241320
    
    2  1
    $MOL
    
    -INDIGO-11052413202D
    
    6  6  0  0  0  0  0  0  0  0999 V2000
    10.2348   -7.2251    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    11.9652   -7.2246    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    11.1016   -6.7250    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    11.9652   -8.2255    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    10.2348   -8.2300    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    11.1038   -8.7250    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    3  1  2  0  0  0  0
    1  5  1  0  0  0  0
    5  6  2  0  0  0  0
    6  4  1  0  0  0  0
    4  2  2  0  0  0  0
    2  3  1  0  0  0  0
    M  END
    $MOL
    
    -INDIGO-11052413202D
    
    6  6  0  0  0  0  0  0  0  0999 V2000
    10.1098   -9.5751    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    11.8402   -9.5746    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    10.9766   -9.0750    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    11.8402  -10.5755    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    10.1098  -10.5800    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    10.9788  -11.0750    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    3  1  2  0  0  0  0
    1  5  1  0  0  0  0
    5  6  2  0  0  0  0
    6  4  1  0  0  0  0
    4  2  2  0  0  0  0
    2  3  1  0  0  0  0
    M  END
    $MOL
    
    -INDIGO-11052413202D
    
    6  6  0  0  0  0  0  0  0  0999 V2000
    14.0348   -8.5251    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    15.7652   -8.5246    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    14.9016   -8.0250    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    15.7652   -9.5255    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    14.0348   -9.5300    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    14.9038  -10.0250    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
    3  1  2  0  0  0  0
    1  5  1  0  0  0  0
    5  6  2  0  0  0  0
    6  4  1  0  0  0  0
    4  2  2  0  0  0  0
    2  3  1  0  0  0  0
    M  END
    $DTYPE Name
    $DATUM Asderwydfgewsghdjedghdfertsdfg
    $DTYPE Reference
    $DATUM Not available
    $DTYPE Reaction Conditions
    $DATUM  

Actual behavior When 'Reaction Conditions text' field is empty, clicking on placeholder text on canvas results in a blank line, with no visible text

Expected behavior If the 'Reaction Conditions text' field is empty, either no placeholder should appear on the canvas

Screenshot

2024-11-05_14h24_21

Desktop:

Ketcher version [Version 2.26.0-rc.7] Indigo version [Version 1.27.0-dev.1]

Bug foun while pre-testing: https://github.com/epam/Indigo/issues/2559

ivanmaslow commented 5 days ago

The fix is verified on on CI-CD SA environment with Ketcher-Master, Indigo-2404-ket-to-rdf branches:

No additional new lines are added in this case: image