Open NShaforostov opened 3 years ago
BUG was found:
Missing "Clear column filter" button in the "Chr" column when filtering is applied to this column
@mzueva @DmitriiKrasnov @rodichenko
Fixed and verified
Enhancement:
"Loading Genes" is displayed for the Gene panel if no dataset has been selected.
This behavior can confuse the user and it is not obvious that you just need to select a dataset. After a conversation with @DmitriiKrasnov , we came to the conclusion that it is better to remove this loader in order to avoid misunderstandings on the part of users
@mzueva @NShaforostov @DmitriiKrasnov @rodichenko
Fixed and verified
Bug was found:
Missing mandatory Name column in the Gene table
Extra Details Name column can be added by clicking on gene value in the additional columns. It seems that we have 2 columns: mandatory and additional with the same name
@DmitriiKrasnov @rodichenko @mzueva Fixed and verified
Bug was found: 2 additional columns (Source and Gene Source) are disaplyed with the same name in the Gene table
Steps to reproduce:
Expected result: 2 columns should be displayed in the table: Source and Gene Source Actual result: 2 columns are displayed with the same name: Gene Source
@mzueva @DmitriiKrasnov @rodichenko
Fixed and verified
In the gene table displays the columns previously selected for another dataset.
Steps to reproduce:
Expected result:
No ccdc_id column in the NC_003071 table
Actual result:
ccdc_id column displays in the NC_003071 table
Extra details: The same behavior for all additional columns. Columns can be hidden by unchecking them in the previous dataset
@mzueva @rodichenko @DmitriiKrasnov
Verified
BUG was found: A column is still selected in the additional menu after hiding it on the table
Steps to reproduce:
Expected result: Hidden column (e.g. Chromosome) should not be selected in the additional menu Actual result: Hidden column (e.g. Chromosome) is selected in the additional menu Extra details: Hidden column appears again in the table after reloading the page The same behavior in the Variants panel
@mzueva @rodichenko @DmitriiKrasnov
"Won’t be fixed. It was decided to leave this behavior as it is for the moment after conversation with @mzueva
BUG was found: No results in the table when filtering by existing values in the "Frame" column
Steps to reproduce:
Expected result: GENE table should be filtered by entered (0) value in Frame column Actual result: Filter is applied to the Frame column. No records were found in the table
@mzueva @rodichenko @DmitriiKrasnov
Verified
BUG was found: The values in the Source column are not sorted
Steps to reproduce:
Expected result:
Values in the Source column should be displayed according to the applied sorting:Acs or Desc
Actual result:
The order of the values in the Source column does not change when sorting is applied:
Acs
Desc
Extra Details: These data comes from server
@mzueva @rodichenko
Partly fixed
Front and back values are the same now, but sorting is wrong
Good to fix: The GENE table disappears when filtering by a nonexistent value is applied.
It would be great that GENE table header and the applied filter to be displayed in the GENE panel as in Variants panel
@rodichenko @mzueva @DmitriiKrasnov
Verified
Good to fix: Reset filter and Hamburger icon are displayed in the different order in the bar for Genes and Variants panels GENES panel
Variants panel
It would be better to bring it to a common view
@rodichenko @mzueva @DmitriiKrasnov
Fixed
Reset filter displays first for now for Variants and Genes panels
Bug was found: The value 0 is not stored in the filter search fields of "Score" column
BUG was found: The values in the Source column are not sorted
Steps to reproduce:
Expected result: Filter should be applied. The values by which the filter is applied are displayed in the FROM and TO fields: -1; 0 Actual result: Filter is applied. "-1" value is displayed in the FROM field only. "TO' field is empty Extra Details: The same behavior for the following columns in Variants panel:
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: Filtering and sorting are not reset when switching from one dataset to another
Steps to reproduce:
Expected result:
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: The page is reloading when clicking on any of the GENE table fields
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: Reset genes filter button doesn't disappear if all filters are empty
Preconditions:
Steps to reproduce:
Expected result: Reset filter button isn't displayed in the right upper corner
Actual result:
Reset genes filter button displays in the right upper corner when all filters are empty
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: Sequence query is not filled from context menu blastn / blastp in the GENES table
Steps to reproduce:
Expected result: Query sequence field is filled by corresponding sequence of gene
Actual result: Query sequence field is empty
Extra details: The same behavior for BLASTp search This behavior was found for gene with data from bug only. There may be other examples, but they have not been found yet
@mzueva @rodichenko
Verified
Bug was found: Nucleotide sequence displays in the BLASTp search
Steps to reproduce:
Expected result: Query sequence field should be filled by protein sequence
Actual result:
Query sequence field is filled by nucleotide sequence
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: Empty GENE table displays after scrolling the GENE table and opening any panel from context menu
Steps to reproduce:
Expected result: GENES table should be filled Actual result: Empty GENES table is displayed
Extra details: The data is displayed again if you apply a scroll The current behavior was found on MAC only
@rodichenko @mzueva
BUG was found: A column is still selected in the additional menu after hiding it on the table
Steps to reproduce:
- Select NC_003071 dataset in the Datasets panel
- Go to GENE panel
- Expand Additional menu
- Select any column (e.g.Chromosome)
- Open expand menu in the added column
- Click on Hide Column
- Expand Additional menu
Expected result: Hidden column (e.g. Chromosome) should not be selected in the additional menu Actual result: Hidden column (e.g. Chromosome) is selected in the additional menu Extra details: Hidden column appears again in the table after reloading the page The same behavior in the Variants panel
@mzueva @rodichenko @DmitriiKrasnov
It was decided to leave this behavior as it is for the moment after conversation with @mzueva FYI @DmitriiKrasnov @rodichenko
BUG was found: BLASTn tab displays after searching by BLASTp from track and GENE panel
Preconditions:
Steps to reproduce:
Expected result: BLASTp tab should be displayed in the BLAST panel
Actual result: BLASTn tab displays in the BLAST panel
Extra details: The same behavior for searching from track
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: An endless loader displays in the GENE panel after reopening the panel
Preconditions: Close GENES panel if it is opened
Steps to reproduce:
Expected result: GENES menu should be loaded with values inside
Actual result: An endless loader displays in the GENES panel
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: An error displays in the console after opening GENES panel from VIEWS menu
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: Error loading sequence for feature displays instead of a Sequence in the Feature Info window
Steps to reproduce:
Expected result: Sequence should be displayed in the window (e.g. CTTCTTCACTTGTCAGCTCT)
Actual result: No sequence in the Feature info window. There the error is displayed: Error loading sequence for feature
Extra details: 400 error displays in the Console and Network
@mzueva
Verified
Bug was found: Duplicate GENE's Type selenocysteine is displayed in the Type column
Steps to reproduce:
Expected result: Values in the filter must not be repeated. selenocysteine value is only one in the list
Actual result:
Type filter has two selenocysteine values
Extra details: It is impossible to unclick selected selenocysteine type. The same behavior in Feature menu in Gene track
@mzueva
Verified
Bug was found: A dash is displayed in the Type column of GENES panel
Steps to reproduce:
Expected result: "Default value" displays in the row Actual result: Dash is displayed in the TYPE column
Extra details: Such values come from the server and it was previously planned that instead of a dash there would be some default value
@sidoruka @mzueva @rodichenko
Fixed and verified
Bug was found: Incorrect display of spelling of genes types (3UTR, 5UTR) display in the GENES panel and filters
Expected result: The search results display in the panel. The correct type names are displayed in the filters and on the panel: 3UTR, 5UTR Actual result: The following names of types display in the panel and in filters: 3%27UTR, 5%27UTR
@mzueva @SilinPavel @sidoruka
Bug was found: Duplicate GENE's Type selenocysteine is displayed in the Type column
Steps to reproduce:
1. Select **SV_Sample1** dataset in DATASETS panel 2. Go to GENES panel 3. Select **Show filters** in **Hamburger menu** 4. Сlick on the filter input field of the Type column 5. Look at expanded menu of Type's column
Expected result: Values in the filter must not be repeated. selenocysteine value is only one in the list
Actual result: Type filter has two selenocysteine values
Extra details: It is impossible to unclick selected selenocysteine type. The same behavior in Feature menu in Gene track
![]()
@mzueva
@Tatyana2022 should be resolved by f501b9b986b15728aceebc08c155c564cde704b4
Verified
Bug was found: A dash is displayed in the Type column of GENES panel
Steps to reproduce:
1. Select **NC_003071** dataset in DATASETS panel 2. Go to **GENES** panel 3. Open filters in **Hamburger** menu 4. Select **Id(attr)** column 5. Find row with **nc_003071** value 6. Look at value in **TYPE** column
Expected result: "Default value" displays in the row Actual result: Dash is displayed in the TYPE column
Extra details: Such values come from the server and it was previously planned that instead of a dash there would be some default value
![]()
@sidoruka @mzueva @rodichenko
@Tatyana2022 @mzueva @rodichenko it is because source
feature from gbk was translated to empty
feature in gene fine
we agreed to remove colored tag for such features on ui
Fixed and verified
Bug was found: An error is displayed after sorting by empty column and scrolling down
Steps to reproduce:
Expected result: The GENES panel should be scrolled down Actual result The GENES table became empty. An error displays in the page:
Extra details: The same behavior for all columns with empty value
@mzueva @SilinPavel @sidoruka
Fixed and verified
Bug was found: An error is displayed after sorting by empty column and scrolling down
Steps to reproduce:
1. Go tom NGB 2. Select **SV_Sample1** dataset in DATASETS panel 3. Go to **GENES** panel 4. Sort Asc by Name column 5. Scroll to the very bottom
Expected result: The GENES panel should be scrolled down Actual result The GENES table became empty. An error displays in the page:
![]()
Extra details: The same behavior for all columns with empty value
@mzueva @SilinPavel @sidoruka
@Tatyana2022 should be fixed by 1f73d74dcf1bb4c7500d2a7808445472a43734da
Verified
Bug was found: The context menu does not close when the Info window is opened
Steps to reproduce:
Expected result: Info window is opened. Context menu window should be closed Actual result Info window is opened. Context menu displays above the Info window
@mzueva @rodichenko @DmitriiKrasnov
Verified
Bug was found: Empty GENE table displays after scrolling the GENE table and opening any panel from context menu
Steps to reproduce:
- Select SV_Sample1 dataset
- Open GENES panel
- Scroll down the table
- Right click on any row
- Click on any button in context menu(e.g. BLASTn search)
- Go back to GENES panel
Expected result: GENES table should be filled Actual result: Empty GENES table is displayed
![]()
Extra details: The sam e behavior The data is displayed again if you apply a scroll The current behavior was found on MAC only The same behavior when clicking on the maximise/minimise button in the header @rodichenko @mzueva
@Tatyana2022 85f74e1 should fix that
Docs were added via #566 and located here.
Background
Currently, users can view different features (genes, transcripts, exons, etc.) at a genome and their info only at GENE tracks. It would be convenient to have an ability to view all features list in a separate panel. In this panel, the feature names, positions at a genome and other info might be presented.
Approach
View
Add a new panel ("Genes") that should display a list of genes/transcripts/exons and other features of the current dataset (from corresponding GFF/GTF files). That panel shall be being opened as other panels:
ALT + G
The "Genes" panel should be being opened at the right side of the page and have a look like:![image](https://user-images.githubusercontent.com/45459424/126311154-80338d4d-1f55-4794-be61-ab23bcab517b.png)
This panel should contain a list of features in a table view with the following columns:
+
(forward) or-
(reverse).Additionally, the panel should contain in the right-upper corner the block of controls (like "Variants" panel):![image](https://user-images.githubusercontent.com/45459424/118624255-a9380200-b7d1-11eb-8e63-90816c19cc1b.png)
Other options
Sorting
User shall have the ability to sort the table data by any column (except "Info" and "Molecular view"). The sorting should be implemented similar to the existing approach (e.g. as at the "Variants" panel):
If for the column any sorting is set (ascending/descending) - the corresponding icon should be displayed at the column header.
Filters
User shall have the ability to filter the table data by column(s) content. The filtering should be implemented similar to the existing approach (e.g. as at the "Variants" panel):
from
value for the filter (means the minimal position from which the filtered features should start)to
value for the filter (means the maximal position by which the filtered features should finish)from
and/orto
values for the filterPaging
The "Genes" table should support pagination. The pagination should be implemented similar to the existing approach (e.g. as at the "Variants" panel) - user can use mouse scroll to auto-switch between pages.
Workflows
Navigation to track
User shall have the ability to navigate to the corresponding genome location at the GENE track by click any row in the "Genes" table, e.g.:![image](https://user-images.githubusercontent.com/45459424/125495147-8be29654-d377-44b5-a585-046359bb6b77.png)
Details of the navigation:
Display feature info
User shall have the ability to view the info details about the certain feature by click the "Info" button in the row of that feature in the "Genes" panel, e.g.:![image](https://user-images.githubusercontent.com/45459424/125495400-5d43db14-8358-4777-81bf-b6eafafa002e.png)
Details:
Display attributes
User shall have the ability to display attributes for a feature as additional columns in the "Genes" panel, e.g.:![image](https://user-images.githubusercontent.com/45459424/126311980-178c961b-f0d7-4764-a559-353f677b8720.png)
Displaying of such attribute columns should be performed via additional menu in the right-upper corner of the panel. This menu should contain the full list of attributes from the current dataset, e.g.:![image](https://user-images.githubusercontent.com/45459424/126312194-86dee788-f2e0-495f-8919-097d35dc6ae7.png)
If the certain attribute is enabled in that menu - the corresponding column is displayed in the "Genes" panel. To hide the additional column user can:
For additional columns, all options described above (sorting, filters) shall be being applied.
"Origin" of these attributes is the "attributes" column of the GENE file.
Edit attributes
User shall have the ability to modify the attribute values manually via GUI - see details in #496.
Use context menu
User shall have the ability to open the context menu - by the mouse click at the feature in the table. This menu should be similar to the context menu that user can view by the click the feature in the Browser. Possible items in such context menu should be:
featureCounts
files, this item should not be shownView a visualized 3D protein structure
User shall have the ability to open a 3D structure visualization of the certain feature by click the "Show 3D structure" item in the feature context menu in the "Genes" panel, e.g.:
Details:
RCSB
database for a selected feature