Open mzueva opened 3 years ago
@rodichenko Some minor improvements:
@rodichenko another minor improvement: When user opens the Manual scale pop-up (in the Bar Graph display mode):
0
, to the field To should be set maximal value from all currently displayed barsBug was found: The checkbox setting for the "Log scale" field is not saved in Manual scale
Prerequisites
Steps to reproduce:
Expected result: The checkbox is set to the Log scale field. Actual result: The checkbox is not set to the Log scale field. Extra Details: The checkbox is not set to the Log scale field in the Displays menu also
@rodichenko
Verified
Bug was found: An error is displayed in the console when selected any one source and Log scale in multi track
Prerequisites: Open Console (F12)
Steps to reproduce:
Expected result:
No errors in the console
Actual result:
An error displays in the console:
app.bundle.js:514 Uncaught TypeError: Cannot read properties of null (reading 'height') at Sprite.get (app.bundle.js:514) at CoordinateSystem.value (app.bundle.js:1025) at BarChartSourceRenderer.value (app.bundle.js:1025) at app.bundle.js:1024 at Array.forEach (<anonymous>) at FCBarChartRenderer.value (app.bundle.js:1024) at FCBarChartRenderer.value (app.bundle.js:729) at FCBarChartRenderer.value (app.bundle.js:1024) at FeatureCountsTrack.value (app.bundle.js:1023) at FeatureCountsTrack.value (app.bundle.js:717)
Screenshots:
@mzueva @rodichenko
Verified
Bug was found: Unable to uncheck a "Features" display
Prerequisites: Dataset = sv_sample1 File = sv_sample_1.byGTF.featureCounts
Steps to reproduce:
Expected result: Features display should be unchecked. Bar Graph display should be selected automatically Actual result: Features display is still selected. Extra details: The Features checkbox is unchecked only after switching to the Bar graph display
@mzueva @rodichenko
Verified
@Tatyana2022
Bug was found: An error is displayed in the console when selected any one source and Log scale in multi track
and
Bug was found: Unable to uncheck a "Features" display
should be fixed by #595 and 8f1b3b5
Fixed
Docs were added via #566 and located here.
Background
Due to #462, NGB supports
featureCounts
format. Currently,featureCounts
tracks are displaying only in a single view type in the "Browser" - similar to genes or features. It would be convenient to support a histogram view as well - e.g. bar graph with heights proportionally to feature counts.Approach
Add a new item to the
featureCounts
track header to have the ability to select a view type - Display. This item shall open a list of possible view types:If the "Bar Graph" view is selected -
featureCounts
track shall be displayed as a histogram:featureCounts
file - the own bar should be drawn. Bar height in each position shall be proportional to the value of read counts in this positionfeatureCounts
file, shall be displayed in the left-upper corner of the trackExample:
In case when the origin
featureCounts
file has several source SAM/BAM files used as the input:Example for the
featureCounts
track with 3 read counts sources:Example for the
featureCounts
track with 2 read counts sources and zoomed-out:Note: on big scales with "Bar Graph" mode, to not confuse users we shall show only info message like "Zoom in to see features" (default zoom level threshold should be
10m
bp).Additionally, only in case of multi-inputs, the item "Sources" shall appear in the track header. User shall have the ability to click this item to select source SAM/BAM files to show as sub-tracks. By default, all sources (sub-tracks) shall be displayed:
Notes:
featureCounts
tracks are selected - in the common menu, the item "Sources" shall not appearOther options
For the histogram view:
featureCounts
track as wellWIG
tracks, e.g. (see #333 for details). The only difference is that on the form for manual scale there should be only the following additional options:featureCounts
tracks"WIG
tracks as well