search

epam / OSCI

Open Source Contributor Index
https://opensourceindex.io/
GNU General Public License v3.0
155 stars 94 forks source link

Something was missed in Industry drop-down list #191

Open zlidzen opened 6 months ago

zlidzen commented 6 months ago

Hello, I examine https://opensourceindex.io/

What I did: -Click Industry menu filter -Uncheck "select all" -Scroll down -Check empty line between lines "Healthcare & Pharma" and "Public Sector"

What I got: -Line for FARFETCH organization.

What I expect: -I don't have empty lines inside Industry drop-down menu filter

I check - osci/preprocess/match_company/company_domain_match_list.yaml I assume that industry field was missed for FARFETCH company

Possible solutions:

  1. Add industry field for FARFETCH with value: "Retail & Hospitality" or "Other"
  2. Add rules fields in yaml file. Example: "we have set of mandatory fields, this fields cannot be empty"

Thanks. empty_line1

cm-howard commented 6 months ago

Thanks for the details on this one @zlidzen and for raising the PR (https://github.com/epam/OSCI/pull/192)

I've got @vlad-isayko tagged to review so we can hopefully merge soon.

pnatashap commented 5 months ago

Looks like autochecker is needed for this file to make it accurate all the time