search

epam / ai-dial-chat

A default UI for AI DIAL
https://chat.lab.epam.com
Apache License 2.0
57 stars 24 forks source link

[Redesign] Windows are closed automatically if to click outside the window. We want to allow the windows to be closed on X only. #1918

Closed VolhaBazhkova closed 2 weeks ago

VolhaBazhkova commented 1 month ago

EPAM AI DIAL chat version

0.16.0

What happened?

Now all pop-up windows are closed if to click out side of them. For example, while publication request there could be an error. If to close the error on 'x', clickoutside action is triggered and publication window is closed automatically. It confuses as user has to start publication from the beginning.

Example: https://github.com/user-attachments/assets/aa46ef23-2ca8-4647-8bba-c5b1db9498c1

Expected: We want to allow pop-ups to be closed on X only, need to forbid to close the pop-up automatically on clicking outside the window. No need to do this for any confirmation pop-ups.

Confidential information

IlyaBondar commented 1 month ago

Note: I suggest to add ignoreParentClass into Modal-component and pass outsidePress into useDismiss

VolhaBazhkova commented 4 weeks ago

Discussed on daily and we decided to update the ticket: initial problem: Windows are closed automatically if to close the error on 'x'. Example, with publish and unpublish window. decided to fix it: We want to allow pop-ups to be closed on X only, need to forbid to close the pop-up automatically on clicking outside the window.

VolhaBazhkova commented 2 weeks ago

Verified on staging env successfully. The following forms can be closed now on 'X' or Cancel buttons only. They remain on the screen if to click on any area outside the windows:

All other confirmations and some windows where user doesn't need to type any info manually can be closed automatically on the click outside. For example: