Open sidoruka opened 3 years ago
The following scope of issues have to be resolved in order to provide complete Windows experience in Cloud Pipeline.
@Wedds Could you please implement the following tasks?
[x] Support tools scanning
Currently Windows tools scanning fails due to NullPointerException in API. It seems that the Clair itself can scan those images and the fix should be pretty simple.
[x] Install cloud data desktop application
Cloud Data desktop application should be installed to Windows node during launch.ps1 execution. All data storage allowed to owner should be available in Cloud Data desktop application.
Ask @rodichenko about the details on how to install and configure Cloud Data desktop application.
[x] Disable Windows node reassignment
Autoscaler should not reassign Windows nodes. Autoscaler can determine Windows workstation by the corresponding node label.
[x] Disable hot node pools of Windows nodes
Hot node pools of Windows nodes should not be allowed.
[x] Support data storage mounts as disks
NFS data storages should be mounted to Windows node during launch.ps1 execution. All NFS data storages allowed to owner should be available as disks accessible from Windows Explorer.
[x] Terminate Windows node once its run finishes
[x] Allow to run unscanned tool versions
[x] Use Windows tool platform in scan results
[x] Resolve kubelet node labels race condition
[x] Investigate different home directory name resolution
[x] Prepare Windows support pull requests
[x] Review Windows support pull requests non-API changes
[x] Remove extra shortcuts from desktop
[x] Remove instance details from desktop
[x] Remove extra items from taskbar
[x] Disable Windows tools scanning
[x] Replace OWNER_GROUPS run parameter with a contextual preference which defaults to Users
[x] Merge Windows support pull requests to develop
@rodichenko Could you please implement the following tasks?
[x] Disable commit for Windows runs
Commit button on run page should be hidden if the run's platform
equals to windows
.
[x] Support tools instance images setting
Add an additional optional field to tool settings page called instance image.
[x] Remove add to white list and scan buttons from tool versions page for Windows tools
[x] Show tools platform as Linux/Windows icon
[x] Remove limit mounts sections from tool settings and launch pages for Windows tools
[x] Remove allow sensitive storages checkbox from tool settings page for Windows tools
[x] Remove configure cluster button from tool settings and launch pages for Windows tools
[x] Add distinct run capabilities for Linux and Windows (empty for now) tools
[x] Remove vulnerabilities report and packages tabs from tool version details page for Windows tools
[x] Do not allow Windows tools in hot node tools
[x] Remove browse button from run page for Windows runs
[x] Remove monitor tab from node page for Windows nodes
[x] Add missing general info to node page for Windows nodes
[x] Remove Windows scan description from tool version page for Windows tools
@mzueva Could you please implement the following tasks?
Tasks for myself.
@tcibinan GUI tasks are implemented (6f6344729fabcb103ca3d463ce98ef7ec314d210, branch gui-windows-based-tools-1832
)
@mzueva @sidoruka @tcibinan GUI part merged (#2017)
Warning message "A large number of the object data storages are going to be mounted for this job"
shouldn't be shown at launch of Windows tool.
Pause and Versioned Storages links don't work now and should be removed.
On Windows machine:
Authentication succeeded for Cloud Storage Drive mapping/ Please follow instructions to configure....
is shown several times at openning Windows machine. Final message is StorageMapping [ERROR] WebDav mapping: Drive mapping failed!
. Is it correct message or it should give reason of error?Issues:
Big files copy research: | File size | 976.59Mb | 1.5Gb | 4.7Gb |
---|---|---|---|---|
Copy file via CloudData: | ||||
Windows --> Storage | - File is copied - File appears in the storage after reload only |
- File is copied - File appears in the storage after 2-3 min reload |
- Progress bar displays that file is copied -After that all info exclude modal name disappears from the CloudData modal - File doesn't appears in the storage |
|
Windows --> FS Storage | - File is copied - File appears in the storage after reload only |
- File is copied - File appears in the storage after reload only |
- File is copied - File appears in the storage after reload only |
|
Storage --> Windows | The file is copied in about 7 min | The file is copied in about 8 minutes | The file is copied in about 35 minutes | |
FS Storage --> Windows | The file is copied in about 12 min | The file is copied in about 12 minutes | The file is copied in about 42 minutes | |
Copy file via WindowsExplorer: | ||||
Windows --> Storage | - File is copied - The process hangs for about a 1min by 99% |
- File is copied - The process hangs for about a 1min by 99% |
- The process reaches 99% in a 1min and hangs for 2 min - After that the Replace or Skip Files modal appears with info that The destination already has a file named " ... " - Copied file with 0 size appears in the storage |
|
Windows --> FS Storage | - File is copied - The process hangs for about a 1min by 99% |
- File is copied - The process hangs for about a 1min by 99% |
- The process reaches 99% in a 1min and hangs for 2 min - After that the Replace or Skip Files modal appears with info that The destination already has a file named " ... " <Click on Replace file option gives error message The file exceeds the limit allowed and cannot be saved. - Copied file with 0 size appears in the storage |
|
Storage --> Windows | The file is copied in about 1 min | The file is copied in about 1 min | - Error message The file exceeds the limit allowed and cannot be saved. - The file isn't copied |
|
FS Storage --> Windows | The file is copied in about 1 min | The file is copied in about 1 min | - Error message The file exceeds the limit allowed and cannot be saved. - The file isn't copied |
Pause and Versioned Storages links don't work now and should be removed.
@maryvictol should be fixed with ccf7b3e3685f11bf35580a3ea0f727b3b261682f
Warning message
"A large number of the object data storages are going to be mounted for this job"
shouldn't be shown at launch of Windows tool.
@maryvictol warning message was removed (f24a58360d2ff5be66abb7467c93f8f076837345)
Pause and Versioned Storages links don't work now and should be removed.
@maryvictol should be fixed with ccf7b3e
Verified as fixed
Warning message
"A large number of the object data storages are going to be mounted for this job"
shouldn't be shown at launch of Windows tool.@maryvictol warning message was removed (f24a583)
Verified as fixed
Background At the moment, Cloud Pipeline is a fully Linux-based solution, but there is a growing demand on running Windows-based apps as well (especially for the
Modelling and Simulation
,PK/PD
use cases). There was an attempt (#755) to implement this via the Windows containers, but it failed as only "headless" applications can be run this way. The majority of the relevant apps are GUI-based. Let's get back to this task and implement it in a different way. The final goal is the same: "Overall, the look and feel of Windows-based apps shall be the same as for the Linux (to the best possible extent)"Approach
Windows Server Containers 2019
)Tool
from the library as usual. Such tool shall contain a corresponding Windows AMI in it's confignginx
service with the port forward ruleZ:
pipe
CLI shall be preinstalled, as we do for Linux jobsAction Items
node-up/down/reassign
scripts changes. To spinup windows VMsinit
script changes. To preconfigure Windows VMnginx
proxy