epam / cloud-pipeline

Cloud agnostic genomics analysis, scientific computation and storage platform
https://cloud-pipeline.com
Apache License 2.0
145 stars 59 forks source link

Allow to set default mount limits on a per-user basis #2210

Open sidoruka opened 2 years ago

sidoruka commented 2 years ago

Background At the moment, Cloud Pipeline allows settings environment variables (and thus CP_CAP_LIMIT_MOUNTS) using the following options:

But for certain cases - users would benefit from setting default list of mounted storages (e.g. for the ROLE_ADMIN).

Approach

sidoruka commented 2 years ago

Shall be backported to release/0.16

rodichenko commented 2 years ago

@sidoruka @mzueva backported to release/0.16 (11feac47f786110fcd04dedaa42620aba7eaba2b)

maryvictol commented 2 years ago

Case:

  1. Only Storages to which non-admin user doesn't have any permissions are added to the Tool's Limit mounts list.
  2. Non-admin user launch this Tool with Custom Settings

Actual results:

[Questions] What behavior is expected in that case? And should be the user-level settings are applied in that case?

NShaforostov commented 2 years ago

Test cases were created by #2253 and located here.

NShaforostov commented 2 years ago

e2e-tests were implemented via #2274.

NShaforostov commented 2 years ago

Daily e2e-tests results are located and updated here (for AWS).