epam / hub-extensions

Hub CLI extensions
Mozilla Public License 2.0
0 stars 2 forks source link

Domain name used where it shouldn't #49

Closed akranga closed 1 year ago

akranga commented 1 year ago

Reproducible in this stack: https://github.com/epam/hub-kubeflow-stacks/tree/ff7d147bff387d36eeebf532f522f5f0b0e51c24

hubctl stack init
hubctl stack configure

Then azure extension will see that DNS_DOMAIN has not been defined in the hub.yaml by the user and produces following outputs (this is correct

...
* Skipping DNS setup due to neither dns.domain nor HUB_DOMAIN_NAME env variable defined
  To manage DNS please add parameter to your hubfile:
  - name: dns.domain
    value: example.com
  Or to get autogenerated domain
  - name: dns.domain
    fromEnv: HUB_DOMAIN_NAME
...

Nevertheless less resulting .env file will contain something similar to

HUB_STACK_NAME="cheerful-murdoc-918"
HUB_DOMAIN_NAME="cheerful-murdoc-918.epam.devops.delivery"

Expected result:

HUB_STACK_NAME="cheerful-murdoc-918"
HUB_DOMAIN_NAME="cheerful-murdoc-918"

Otherwise component of a stack may incorrectly think dns.domain and try to use it as a fully qualified (and reachable) domain name

akranga commented 1 year ago

/close