epam / hub-extensions

Hub CLI extensions
Mozilla Public License 2.0
0 stars 2 forks source link

Incorrect behaviour of params -c <component> value <val> #80

Closed oginskis closed 1 year ago

oginskis commented 1 year ago

I have component parameters defined as follows (the order of parameters matters):

- name: kubernetes
  component: external-dns
  parameters:
  - name: namespace
    value: ns-a
  - name: serviceAccount
    value: account-a

- name: kubernetes
  component: cert-manager
  parameters:
  - name: namespace
    value: ns-b
  - name: serviceAccount
    value: account-b 

When I do (from extension): params -c cert-manager value kubernetes.serviceAccount I get ns-b which is correct

However, when I do: params -c external-dns value kubernetes.serviceAccount I still get ns-b which is not correct

Please fix

akranga commented 1 year ago

@oginskis good catch! There were race condition where component was swallowed by parameter flattening