epam / ketcher

Web-based molecule sketcher
https://lifescience.opensource.epam.com/ketcher/demo.html
Apache License 2.0
470 stars 164 forks source link

Settings for the "attachment point tool" don't update with changed pixel settings #4983

Closed AlekseiKhariukov closed 2 weeks ago

AlekseiKhariukov commented 3 months ago

T-shape attachment points created with the Attachment Point Tool (or loaded from an external file) do not respect 'Bond thickness' global setting and are always drawn with default thickness.

Steps to reproduce:

  1. Add a single bond and an attachment point to a drawing.
  2. Go to Settings->Bonds and change the 'Bond thickness' parameter (e.g. increase up to 6)
  3. See that line width of the single bond has been updated accordingly while line width of the attachment point remain the same.

image

'Bond thickness' setting should apply to attachment points, similarly to bonds.

(?) Related Indigo task - #2070

AnnaKosol commented 2 weeks ago

Steps:

  1. create benzine ring with attachment points Image
  2. change Bond thickness to 0.2 cm
  3. click on Apply button

Actual result: Image attachment point isn't changed thickness

Expected result: attachment point is changed thickness

AnnaKosol commented 2 weeks ago

Steps:

  1. create molecule with primary attachment point Снимок экрана 2024-09-18 в 15 29 47
  2. change setting Bond thickness to 0.2 px
  3. click on Apply button

Actual result: primary attachment point isn't displayed Снимок экрана 2024-09-18 в 15 34 16

Снимок экрана 2024-09-18 в 15 31 27

Expected result: all parts of molecule are displayed regarding settings

Moved this problem to https://github.com/epam/ketcher/issues/5544 after discussing with @rrodionov91

AnnaKosol commented 2 weeks ago

Verified

Снимок экрана 2024-09-19 в 14 22 29

Environment Ketcher Version 2.25.0-rc.1 Build at 2024-09-18; 05:33:09 Indigo Version 1.25.0-dev.1.19-ge314cdb7-wasm32-wasm-clang-12.0.0 Chrome 128.0.6613.138 (arm64) MacOs 14.6