search

epam / ketcher

Web-based molecule sketcher
https://lifescience.opensource.epam.com/ketcher/demo.html
Apache License 2.0
474 stars 164 forks source link

System insert monomer from the library to the canvas even if it shouldn't (and error message is wrong) 3 #5230

Closed AlexeyGirin closed 1 month ago

AlexeyGirin commented 2 months ago

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Go to the Library - Peptide tab
  3. Click on A peptide twice to put two A's on the canvas image
  4. Click between monomers to put cursor between two A's
  5. Click on DACys peptide (C section, it has no R1 connection point)

Actual behavior System split existed sequence on two and adds monomer at the beginning on the second one. And shows error message image

Expected behavior

  1. No monomers should be added. As per requirement:

.....2.2 If monomer being added lacks AP necessary for establishing connections then error message should be displayed and no monomer is added.

  1. Error message text should be The monomer lacks R1 connection point and cannot be inserted at current position image As per requirement:

The monomer lacks (Ri, i – the number of absent AP) connection point and cannot be inserted at current position

Versions

Related issue - https://github.com/epam/ketcher/issues/4878

AlexeyGirin commented 1 month ago

Partially fixed. No monomer insertion happens but error message is wrong. Follow up bug has been created: https://github.com/epam/ketcher/issues/5300