epam / ketcher

Web-based molecule sketcher
https://lifescience.opensource.epam.com/ketcher/demo.html
Apache License 2.0
474 stars 164 forks source link

Replacement of peptide at the end of sequence on preset w/out base works wrong #5245

Closed AlexeyGirin closed 1 month ago

AlexeyGirin commented 2 months ago

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Load from file: Replacement of peptide at the end on preset w_out phosphate works wrong.zip image
  3. Create custom preset without base and name it "No base" image
  4. Select last monomer (in view mode) image
  5. Click on "No base" preset in the library

Actual behavior "Confirm Your Actions" dialog appears image Click YES System removes last peptide from the sequence image

Expected behavior No dialog appears System replace A peptide with @ symbol image

As per requirement:

  1. If the user selects any number of monomers in view mode, and clicks on the monomer card in the library, all selected monomer on the canvas are replaced by chosen monomer from the library each

Versions

Related issue - https://github.com/epam/ketcher/issues/4878

Zhirnoff commented 1 month ago

Tested. Bug fixed.

https://github.com/user-attachments/assets/df868c37-14d2-4049-a84f-845538508e47

Desktop:

Ketcher version [Version 2.24.0-rc.2] Indigo version [Version 1.23.0-rc.2]