epam / ketcher

Web-based molecule sketcher
https://lifescience.opensource.epam.com/ketcher/demo.html
Apache License 2.0
505 stars 174 forks source link

Fix minimal distances for mult-tail validation in KET format #5761

Closed AlexanderSavelyev closed 1 month ago

AlexanderSavelyev commented 1 month ago

Steps to Reproduce

  1. Insert structure from smiles "CC"
  2. Insert default multi-tail arrow
  3. Increase the bond length twice
  4. Select all
  5. Save as Ket, copy the ket file into clipboard buffer
  6. Paste the ket file

Actual behavior Error message appears - cannot deserialize input JSON

Expected behavior No errors, Structure is pasted but with a smaller size The following validation rules should be changed for KET file (only for KET, the UI behavior should not be changed)

MIN_TAIL_DISTANCE - 0.01. MIN_HEAD_LENGTH - 0.01. MIN_TAIL_LENGTH - 0.01 MIN_TOP_BOTTOM_OFFSET - 0.01 MIN_HEIGHT - 0.01

Desktop (please complete the following information):

Note

ivanmaslow commented 1 month ago

12 manual tests and files are updated, minimal sizes are retested on UI and for loading from KET on Nightly env.

rrodionov91 commented 1 month ago

Need merge into 2.26

Zhirnoff commented 1 month ago

Tested. Bug fixed. 2024-10-25_15h11_36 2024-10-25_15h11_51 2024-10-25_15h12_25

https://github.com/user-attachments/assets/5cfb571c-7b1b-4687-afe1-87e155056ffa

Desktop:

Ketcher version [Version 2.26.0-rc.6] Indigo version [Version 1.25.0-rc.4]