search

epam / miew

3D Molecular Viewer
https://miew.app
MIT License
133 stars 42 forks source link

Upgrade application to React 18 #513

Open NataliaDSmirnova opened 7 months ago

NataliaDSmirnova commented 7 months ago

App uses React 16. It's time to upgrade.

paulsmirnov commented 7 months ago

It seems the application uses Redux incorrectly. It puts non-serialized objects into the store (e.g., Miew or ColorerList):

https://github.com/epam/miew/blob/31e0e41e6786508f24d884dee1f72624bd6b279b/packages/app/src/components/viewer/MiewViewer.jsx#L24-L25

https://github.com/epam/miew/blob/31e0e41e6786508f24d884dee1f72624bd6b279b/packages/app/src/components/viewer/MiewViewer.jsx#L39-L40

It also crashes (#514), but it seems unrelated.

I mean, it's difficult to upgrade and perform regression checks. I'll see what I can do.