epam / mintgate

1 stars 2 forks source link

M1 demo feedback: more realistic test data #49

Closed zahhar closed 3 years ago

zahhar commented 3 years ago

Once Mintgate provides more realistic test data - we have to update test cases.

zahhar commented 3 years ago

Let's discuss what Metadata attributes are mandatory for Collectible.

Standard struct

Metadata {
                title: **mandatory**
                description: **tbd**
                media: **tbd**
                media_hash: **tbd**
                copies: **mandatory, minimum 1**
                issued_at: **automatic**
                expires_at: **not in use**
                starts_at: **not in use**
                updated_at: **automatic**
                extra: **tbd**
                reference: **tbd**
                reference_hash: **tbd**
            },

Discussion

Jshanks21 commented 3 years ago

Title: Agreed. MAX_LENGTH = 16 characters Description: Leave it optional on the contract level and we'll enforce it in the GUI. It's possible we may not make this field mandatory in the GUI in the future. No MAX_LENGTH limit here. Media: Understood. This will be required and should just be any link. Media_Hash: We are not hosting on IPFS, but we would like this to be optional to maintain our flexibility to change our image compression or metadata after token is created if needed or improves performance. Extra: No data seems relevant to add for this field at this time. copies: Just to clarify, this is for copies of any one specific NFT, not all NFTs in the contract, correct? If so, 2^16 would be enough. reference: Sounds great. We may move to IPFS at some point, but for the foreseeable future we will continue to use traditional storage. reference_hash: Even though we are not using IPFS currently, we would like this to be optional to maintain our flexibility to change our image compression or metadata after token is created if needed or improves performance.

Reasoning for optional media and reference hashes:

It would be better for us to use hashes later once we're 100% locked into image compression and metadata schema, however, we are not there yet.

zahhar commented 3 years ago

@Jshanks21 - all understood and will be implemented. One little detail if I may: 16 characters for title sounds like a strict limit, also seems current GUI does not have it. Won't you run into issues accomodating long titles that might include international charactes and emojis? I opened one random marketplace and picket just a few names from home page:

I'd probably woulg go more flex way and limit title with smth between 50..255 characters, otherwise users have to unlock their creative minds to invent descriptive names fitting into 16 char limit :)

zahhar commented 3 years ago

Agreed as follows:

All other fields are optional.

Optional fields, only check max length when given:

Not in use:

zahhar commented 3 years ago

https://www.mintgate.app/api/tokenid/6