epam / mintgate

1 stars 2 forks source link

[LOW] Support for multiple NFT contracts in Marketplace #96

Open acuarica opened 3 years ago

acuarica commented 3 years ago

As follow up to #85, the recommendation from NFT standardisation group is to whitelist trusted NFT contracts. So when/if Marketplace wants to become more open to various NFTs, it either takes the risk of misuse, or the business behind the Marketplace does "onboarding" for NFT Contract that includes whitelisting this NFT contract in the Marketplace.

Our option is to implement the latter. Then following things will happen:

  1. Include new methods to add/remove approved NFT contracts, only mintgate admin account can call these methods.
  2. Upon nft_on_approve you are verifying that request came from one of the verified NFT Contracts.
  3. You can set msg struct individually for every NFT Contract (e.g. ensure GateID is present for MintgateNFT, but not needed for others).
  4. Set individual processing fee - this is important for us as well, because our Marketplace now does not take any % fee itself, as its 2.5% fee is part of NFT Contract.