search

epam / nfstrace

Network file system monitor and analyzer
http://epam.github.io/nfstrace/
GNU General Public License v2.0
151 stars 33 forks source link

Cannot build with CMake 2.8.12 due to unsupported multi-line comment in FindJSON.cmake #26

Closed tripped closed 7 years ago

tripped commented 7 years ago

Trying to build with CMake 2.8.12, I get the following error:

CMake Error: Error in cmake code at
/home/trip/src/nfstrace/cmake/FindJSON.cmake:22:
Parse error.  Expected "(", got identifier with text "and".
CMake Error at analyzers/src/json/CMakeLists.txt:2 (find_package):
  find_package Error reading CMake code from
  "/home/trip/src/nfstrace/cmake/FindJSON.cmake".

Looking at the file in question, it uses a multi-line comment, #[[ ... ]], which is a feature in CMake 3.0 and later. Since README.md indicates that 2.8.12 or later is supported, it might make sense to just revert to single-line comments in that file. It appears to be the only place where multi-line comments are used.

pkarneliuk commented 7 years ago

Let's update minimum required version of CMake to 3.0