search

epartment / nova-dependency-container

A Laravel Nova field container allowing to depend on other fields values
MIT License
382 stars 163 forks source link

Add support for nova-grid-system #122

Open happyDemon opened 4 years ago

happyDemon commented 4 years ago

add support for https://github.com/codenco-dev/nova-grid-system (remove the unneeded container) also added field.class to the main container element

Slgoetz commented 4 years ago

Would love to see this roll out in the next release!

wize-wiz commented 4 years ago

@happyDemon I'll have a look the next coming days

ragingdave commented 3 years ago

Took a look here and I don't see anywhere in the nova code or in the nova-grid-system that adds a field.class property. Where specifically is that coming from? I don't disagree the addtl div is probably not required, but adding something that's field specific feels very specific to someone's specific usage. Also if you do want to move forward, if you can remove the dist js you updated here. We will build prior to the next release.

corgalore commented 3 years ago

@happyDemon, this can get merged if you remove the compiled JS file (field.js) from the PR. Would love to have this right now.

scramatte commented 2 years ago

Hello, I need it for my project. Please fix PR to merge it ASAP. Thank you