epasveer / seer

Seer - a gui frontend to gdb
GNU General Public License v3.0
2.09k stars 66 forks source link

(Possibly Qt upstream and/or GNOME-only issue) Spacing around the UI containers and status bar seems wasteful and bad for usability #159

Closed ell1e closed 10 months ago

ell1e commented 11 months ago

I noticed that the spaces around the UI containers and the space used up by the status bar seem wasteful and like it's downgrading usability significantly by reducing how much useful info I can see while debugging. (I would assume nobody will argue debugging doesn't benefit from a lot of visual input at once, since that's useful to get a big picture idea of why the program is breaking.) The thing is, the spacing outside the various grouped frames serves no purpose even for touch usability, since that is mainly determined by the space right around the buttons that is contained inside these grouped frames and not outside.

This is a screenshot of Seer 2.2 UI as-is: Screenshot from 2023-09-28 12-43-47

This is a quick edit I made of how much space is wasted just by the padding around groups and the status bar, it seems very substantial:

Screenshot from 2023-09-28 12-43-47-2 I acknowledge this might be more Qt's fault and/or how it integrates with GNOME. Nevertheless, it would be useful if someone could look at it. If I should forward this ticket somewhere else, let me know.

epasveer commented 11 months ago

Hi Elllie,

I can tighten up the qt layout here.

epasveer commented 11 months ago

I'm thinking this is gnome related.

Although I use KDE, I think I can duplicate this on one of my boxes by setting up a test user as gnome.

epasveer commented 11 months ago

I'm curios what Qt styles show up under "View->Styles" ?

ell1e commented 11 months ago

Screenshot from 2023-10-03 04-34-44

This was on git commit a29b471911cbc8c7d54468e35107d81a9c502299, I'm updating to latest main right now.

epasveer commented 11 months ago

I am able to duplicate what you see if I use "HighContrast" or the "Adwaita" themes. I'll see if I can improve Seer with these.

epasveer commented 11 months ago

I've tightned up the layout. It boiled down to my use of QGroupBox Under some Qt styles (like the one for gnome), the style would simply draw a blank space instead of a horizontal/vertical lines. Thus resulting in a lot of wasted space. I simply removed the use of QGroupBox.

Here's how it looks under the gnome style.

image

And under the Fusion style. Very little wasted space in either.

image

epasveer commented 11 months ago

Reopening until I hear feedback from ell1e.

ell1e commented 11 months ago

Is this on the main branch? If yes I can test immediately, lemme pull and rebuild real quick

epasveer commented 11 months ago

Yes. I just updated main.

ell1e commented 11 months ago

I just tested it, it looks amazing :heart: thanks so much. Really great update to the overall look, before it really looked a little wobbly and odd, that's all solved now.

epasveer commented 10 months ago

I'm going to close this task. It can be reopened if need be.