search

epcpower / sunspec-demo

MIT License
1 stars 0 forks source link

Help versioneer and pyinstaller get along #13

Closed altendky closed 3 years ago

altendky commented 3 years ago

FWIW, I'm only ok with the big pile of Python code in ci.yml because it should be entirely moved to a proper test suite.

altendky commented 3 years ago

I think the test does effectively check that the file exists since subprocess.run() would raise an exception otherwise. If this were in a test suite I might be a bit tempted to have a dedicated test_executable_exists() case to give a slightly more explicit failure even when only viewing the short list of test names with pass/fail criteria.