epegzz / sass-vars-loader

Use Sass variables defined in Webpack config or in external Javascript or JSON files

MIT License

119 stars 23 forks source link

Remove quotes from strings #31

Closed dword-design closed 5 years ago

dword-design commented 5 years ago

Actually I don't understand why the string quoting is needed. If one wants quotes around the string he can just add them in the string.

Also, the previous code broke box shadows like 0 2px 0 1px rgba(0, 0, 0, 0.1) because of the leading zero.

codecov[bot] commented 5 years ago

Codecov Report

Merging #31 into master will decrease coverage by 0.07%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   98.41%   98.33%   -0.08%     
==========================================
  Files           7        7              
  Lines          63       60       -3     
  Branches       12       11       -1     
==========================================
- Hits           62       59       -3     
  Misses          1        1

Impacted Files	Coverage Δ
src/utils/convertJsToSass.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1752e13...0d3bcc8. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #31 into master will decrease coverage by 0.07%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   98.41%   98.33%   -0.08%     
==========================================
  Files           7        7              
  Lines          63       60       -3     
  Branches       12       11       -1     
==========================================
- Hits           62       59       -3     
  Misses          1        1

Impacted Files	Coverage Δ
src/utils/convertJsToSass.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1752e13...0d3bcc8. Read the comment docs.

epegzz commented 5 years ago

Thank you @dword-design Now merged and released in v5.0.0 👍