epeters13 / pyLoraRFM9x

Fork of the raspi-lora project with improved interrupt handling and reset support
MIT License
6 stars 9 forks source link

version 0.9.3 no attribute self._ack #5

Closed jerryneedell closed 2 years ago

jerryneedell commented 2 years ago

0.9.2 works OK, but if I install 0.9.3 I get

Traceback (most recent call last):
  File "/home/pi/.local/lib/python3.9/site-packages/pyLoraRFM9x/lora.py", line 317, in _handle_interrupt
    if  (header_to == self._this_address and header_flags & FLAGS_REQ_ACK and not header_flags & FLAGS_ACK) and self._ack:
AttributeError: 'LoRa' object has no attribute '_ack'

When using send_to_wait()

edited to add: I think line 317 just hast a typo and has to be changed from

                if  (header_to == self._this_address and header_flags & FLAGS_REQ_ACK and not header_flags & FLAGS_ACK) and self._ack:

to

                if  (header_to == self._this_address and header_flags & FLAGS_REQ_ACK and not header_flags & FLAGS_ACK) and self._acks: