search

epezent / implot

Immediate Mode Plotting
MIT License
4.78k stars 531 forks source link

BeginPlot deprecated #334

Closed Squareys closed 2 years ago

Squareys commented 2 years ago

Hi everyone!

Thanks for building such an awesome library.

I just upgraded to the latest ImPlot HEAD and found ImPlot::BeginPlot() to be deprecated. While I know that it's removal is planned for 1.0, the code otherwise doesn't give a hint at what it was deprecated for. What should I be using instead?

Probably will figure out through git blame, but might be worth extending the comment for other people who stumble over this :)

Best, Jonathan

marcizhu commented 2 years ago

The file implot.cpp explains in detail the changes done to the API, including the deprecation of ImPlot::BeginPlot() and what should be used instead:

https://github.com/epezent/implot/blob/b47c8bacdbc78bc521691f70666f13924bb522ab/implot.cpp#L27-L69

Additionally, the release notes of latest release, v0.13, explain in great detail how the new Setup API works and even has some examples. Finally, the Setup API Proposal (#272) is where we originally discussed this new API and so it too has examples, a description of the API (although it might be a bit outdated), description of its inner workings, etc...

Squareys commented 2 years ago

@marcizhu Thank you very very much!

For some reason I totally missed those release notes, sorry about that! Thank you very much for the kind reply despite the seemingly brain-dead issue opening 🙏

marcizhu commented 2 years ago

No problem! Glad to help :smile: