epezent / implot

Immediate Mode Plotting
MIT License
4.55k stars 503 forks source link

Wrong version number in source files #498

Closed GamingMinds-DanielC closed 12 months ago

GamingMinds-DanielC commented 1 year ago

Small issue: line 23 in all source files and line 63 in implot.h still state version 0.14 in the 0.15 release.

ocornut commented 12 months ago

I have fixed those and added changelog entries with 85573fe.

I would like to update the tag/release now, which may involve republishing the release.

ocornut commented 12 months ago

Done moving the tag: https://github.com/epezent/implot/releases/tag/v0.15

Here's exactly was I did (after I exercised it on a dummy repo).

Interestingly, the updated v0.15 release still shows @epezent as author, and the previous emojis/likes preserved, which is technically all sort of undefined behaviors: it's not totally considered a new release from github pov. Hopefully won't throw anyone's off, only the literal version string + comments were changed.

dg0yt commented 11 months ago

Done moving the tag: https://github.com/epezent/implot/releases/tag/v0.15

Ouch. This changed the tag's content, and caused https://github.com/microsoft/vcpkg/issues/33018.

ocornut commented 11 months ago

Lesson learned, but i guess it was spotted and fixed fast on vcpkg. Should have done a 0.15.1 thing perhaps.

dg0yt commented 11 months ago

spotted and fixed fast on vcpkg.

In fact it is not so fast. vcpkg CI and local builds use "asset caching" based on the checksums. It always hits users which didn't download the asset before...