search

epfl-ecps / channelflow

Channelflow is a software system for numerical analysis of the incompressible fluid flow in channel geometries, written in C++ and MPI-parallelized.
GNU General Public License v2.0
65 stars 29 forks source link

Problems with Solver BiCGStab #18

Closed reetzelhaft closed 4 years ago

reetzelhaft commented 5 years ago

This solver method had two problems:

  1. fcount did not count the number of map iterations. Thus the output in convergence.asc was wrong.
  2. Searches for TW and PO did not work, because the extra constraints were not part of the Jacobian.

I modified the lambda function in the bicgstab solver part, to do 1 and 2 correctly.

codecov-io commented 5 years ago

Codecov Report

Merging #18 into master will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   26.95%   26.95%   -0.01%     
==========================================
  Files          63       63              
  Lines       15328    15331       +3     
  Branches     7254     7260       +6     
==========================================
  Hits         4132     4132              
- Misses      11159    11162       +3     
  Partials       37       37
Impacted Files Coverage Δ
nsolver/newtonalgorithm.cpp 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d334948...a29ae45. Read the comment docs.