search

epfl-lasa / control-libraries

A collection of library modules to facilitate the creation of full control loop algorithms, including state representation, motion planning, kinematics, dynamics and control.
https://epfl-lasa.github.io/control-libraries
GNU General Public License v3.0
27 stars 2 forks source link

Update pybindings and clproto with CartesianAcceleration #250

Closed domire8 closed 2 years ago

domire8 commented 2 years ago

Follow up PR on #248 to add the CartesianAcceleration in the clproto and pybindings.

eeberhard commented 2 years ago

Sorry, I missed a few minor details in #248 that don't affect the code behaviour but still should be touched up :

Line 49 of CartesianAcceleration.cpp is return CartesianTwist(name, random, reference);, should be return CartesianAcceleration(name, random, reference);

In test_cartesian_acceleration.cpp, the test cases CopyTwist, CartesianTwistToStdVector, TestVelocityClamping, TestTwistNorms should be renamed.

domire8 commented 2 years ago

Sorry, I missed a few minor details in #248 that don't affect the code behaviour but still should be touched up :

Line 49 of CartesianAcceleration.cpp is return CartesianTwist(name, random, reference);, should be return CartesianAcceleration(name, random, reference);

In test_cartesian_acceleration.cpp, the test cases CopyTwist, CartesianTwistToStdVector, TestVelocityClamping, TestTwistNorms should be renamed.

Ouf, good catches..Doesn't make our unittests look good.. I also missed something in your PR, we now have an outdated directory structure in the state representations tests