search

epfl-lasa / control-libraries

A collection of library modules to facilitate the creation of full control loop algorithms, including state representation, motion planning, kinematics, dynamics and control.
https://epfl-lasa.github.io/control-libraries
GNU General Public License v3.0
27 stars 2 forks source link

Avoid segfaults in clproto encoding #304

Closed domire8 closed 2 years ago

domire8 commented 2 years ago

This goes in the same direction as the modulo PR and I actually detected this when writing the tests there. Encoding a ParameterInterface that doesn't contain a Parameter instance gives a SEGFAULT and I think we should try to avoid that and throw an error instead.

We don't have clproto exceptions and just throw invalid_argument exceptions. I think at some point we could also have clproto exceptions with meaningful names.

domire8 commented 2 years ago

Now there are some tests in the python dynamical system that fail...