epfl-lasa / control-libraries

A collection of library modules to facilitate the creation of full control loop algorithms, including state representation, motion planning, kinematics, dynamics and control.
https://epfl-lasa.github.io/control-libraries
GNU General Public License v3.0
27 stars 2 forks source link

Remove getter and setter for timestamp #329

Closed domire8 closed 1 year ago

domire8 commented 1 year ago

As discussed, we will refactor the timestamp management in state representation. The timestamp attribute represents - as it was before - the time since last modification. Therefore, we don't want the setter of that attribute anymore, and the getter should be renamed.

I propose here get_epoch but I'm not sure thats a good choice. Maybe the more verbose option get_time_since_last_modification or get_time_since_modification could be nice too.

More to follow in that refactor, I try to scope it well

domire8 commented 1 year ago

We'll do this on aica technology

eeberhard commented 1 year ago

I was going to make the same comment yes