search

epfl-lasa / fri-library-ros

The KUKA FRI library and a nice wrapper for it. We use these in lwr_interface
1 stars 0 forks source link

Make repo public #1

Closed gpldecha closed 5 years ago

gpldecha commented 8 years ago

This repo should be public.

sinamr88 commented 8 years ago

As far as I know, KUKA-FRI is not a open source library and we bought it from KUKA. Just make sure that you don't make this library public.

gpldecha commented 8 years ago

It is open source, make it public.

felixduvallet commented 8 years ago

The code seems to be mostly from Stanford's group, but there is also a .so file. Where does the lib come from: is it generated from the code or did we get it elsewhere?

nisommer commented 8 years ago

I'm pretty sure the .so file is from kuka.

Le mer. 20 janv. 2016 11:45, Felix Duvallet notifications@github.com a écrit :

The code seems to be mostly from Stanford's group http://cs.stanford.edu/people/tkr/fri/html/index.html, but there is also a .so file. Where does the lib come from: is it generated from the code or did we get it elsewhere?

— Reply to this email directly or view it on GitHub https://github.com/epfl-lasa/fri-library-ros/issues/1#issuecomment-173168303 .

KlasKronander commented 8 years ago

What do anyone benefit from making this public? It is only a ros-packaged version of Torsten Kroeger's FRI-wrapper (stanford). I am not sure if the kuka fri components (which are also part of this repo!) are open source or not. I suggest we keep it private to be on the safe side. This library is already available to the public anyway via Stanford.

felixduvallet commented 8 years ago

I have not found any usage of either libFRILibrary_ros.so or libfri_library_ros.so anywhere. This package builds without them, and the lib files are not installed anywhere. Can someone point to a package that requires either lib file?

nisommer commented 8 years ago

The library is loaded at runtime by lwrmain

Le mer. 20 janv. 2016 13:19, Felix Duvallet notifications@github.com a écrit :

I have not found any usage of either libFRILibrary_ros.so or libfri_library_ros.so anywhere. This package builds without them, and the lib files are not installed anywhere. Can someone point to a package that requires either lib file?

— Reply to this email directly or view it on GitHub https://github.com/epfl-lasa/fri-library-ros/issues/1#issuecomment-173186910 .

nisommer commented 8 years ago

ok let met have another look at the code to check.

On Wed, Jan 20, 2016 at 1:26 PM Nicolas Sommer n.sommer@epfl.ch wrote:

The library is loaded at runtime by lwrmain

Le mer. 20 janv. 2016 13:19, Felix Duvallet notifications@github.com a écrit :

I have not found any usage of either libFRILibrary_ros.so or libfri_library_ros.so anywhere. This package builds without them, and the lib files are not installed anywhere. Can someone point to a package that requires either lib file?

— Reply to this email directly or view it on GitHub https://github.com/epfl-lasa/fri-library-ros/issues/1#issuecomment-173186910 .

nisommer commented 8 years ago

Ok, they don't seem to be used anywhere.

On Wed, Jan 20, 2016 at 3:08 PM Nicolas Sommer n.sommer@epfl.ch wrote:

ok let met have another look at the code to check.

On Wed, Jan 20, 2016 at 1:26 PM Nicolas Sommer n.sommer@epfl.ch wrote:

The library is loaded at runtime by lwrmain

Le mer. 20 janv. 2016 13:19, Felix Duvallet notifications@github.com a écrit :

I have not found any usage of either libFRILibrary_ros.so or libfri_library_ros.so anywhere. This package builds without them, and the lib files are not installed anywhere. Can someone point to a package that requires either lib file?

— Reply to this email directly or view it on GitHub https://github.com/epfl-lasa/fri-library-ros/issues/1#issuecomment-173186910 .